Make re module return nil for unmatched captures instead of empty string #1364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This sounds like it will break a lot of code. |
|
@dom96 I doubt that much code uses the peg module. What could be done is create a define() symbol for the old behavior. What is the deprecation path for these things? |
|
This doesn't edit the behaviour of the pegs module. What is the point in creating a define()? You may as well just change your code to check for nil at that point. |
|
oops, I somehow closed this accdently |
|
@Araq do we want this pulled in? |
Conflicts: compiler/ast.nim compiler/nimfix/prettybase.nim compiler/pragmas.nim compiler/sempass2.nim doc/manual.txt koch.nim lib/pure/concurrency/threadpool.nim web/news.txt
Enhance trimcc
|
Yes, it looks scary, but it should merge cleanly onto big-break |
Conflicts: compiler/nim.ini doc/manual.txt doc/tut2.txt koch.nim lib/system/channels.nim readme.txt tools/niminst/niminst.nim tools/nimweb.nim web/download.txt web/news.txt
Fixed FD_SET casing
Conflicts: readme.md
Conflicts: web/news.txt
Add nimblepath so Nim can find Nimble-installed packages out-of-the-box
An empty match will return "" A zero-length match will return nil Add test cases Add news information
- tests included - news.txt updated
|
Closing in preference for a PR against the correct branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(foo)?!=((?:foo)?)