honor --errorMax even for tools (eg nim doc etc)
#14546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
* fix a bug that prevented nim doc compiler/nim on windows
timotheecour
force-pushed
the
pr_honor_errorMax_tools
branch
from
1087687
to
dd3ee3f
Compare
FedericoCeratto
pushed a commit
to FedericoCeratto/Nim
that referenced
this pull request
Jun 4, 2020
* fix a bug that prevented nim doc compiler/nim on windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when errors happen, they can snowball and subsequent ones are often caused by 1st error, which was one of the motivations for
--errorMax.This PR makes
nim docand other tools honor--errorMaxwhen that flag is provided.This helps when investigating issues like #14545 where logs (which i saved here https://gist.github.com/timotheecour/651249370f686efe05462f9dbf342d59) were showing 1400 errors.
after this PR it only shows just a few (the relevant ones) which are the ones shown in #14545
CI failure caused by the usual suspects:
error: 503 (Unable to query remote tags`) => nimble should retry at least once timotheecour/Nim#266 => finally fixing it in fix common source of flaky tests (443 / 503 github errors) by retrying with backoff #14547tfdleaktest on windows refs #14090 #14548