suggest: try to find the implementation of a symbol when def is used #15555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clyybber
reviewed
Oct 12, 2020
alaviss
added a commit
to alaviss/nim.nvim
that referenced
this pull request
Oct 12, 2020
When there are multiple declarations of a symbol, nim.nvim will now create a location list with both the forward declaration and the implementation. The plugin will then jumps to the implementation. Implemented to handle nim-lang/Nim#15555. Should not affect older versions of nimsuggest.
Clyybber
approved these changes
Oct 12, 2020
|
is it intentional that both declarations are only returned when the location from which the definition is asked from is before the definition? proc test(): int
proc test(): int = discard
discard test() # def from here only returns the body |
RSDuck
added a commit
to RSDuck/vscode-nim-1
that referenced
this pull request
Nov 5, 2020
saem
pushed a commit
to saem/vscode-nim
that referenced
this pull request
Nov 6, 2020
Allow for multiple definitions to be returned see nim-lang/Nim#15555
|
Yea, it's a small quirk in the way nimsuggest perform its analysis. To make it work we would need to rethink how nimsuggest functions, and I'm not up for that atm :P |
mildred
pushed a commit
to mildred/Nim
that referenced
this pull request
Jan 11, 2021
…im-lang#15555) * suggest: try to find the implementation of a symbol when def is used * suggest: return all declarations of the symbol on `def`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes nim-lang/nimsuggest#79.
Known issues:
- The forward declaration of the symbol is now inaccessible.