PDCurses wrapper is (almost) done, but will compile #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PDCurses wrapper will compile. However there are a couple dozen consts commented out that were problematic. Also, I got confused about a few procs with function ptrs as arguments. Feel free to fix
Araq
added a commit
that referenced
this pull request
Jul 15, 2012
PDCurses wrapper is (almost) done, but will compile
reactormonk
pushed a commit
to reactormonk/nim
that referenced
this pull request
Apr 7, 2014
PDCurses wrapper is (almost) done, but will compile
Clyybber
pushed a commit
to Clyybber/Nim
that referenced
this pull request
Feb 9, 2022
165: koch: generate zstd archives by default r=alaviss a=alaviss Zstandard is a fast compression algorithm with ratio rivaling that of XZ. Emperical testing on my Ryzen 5 3600 resulted in a massive improvement in compression and decompression speed, in particular: - Zstd is 13% faster than XZ for compression. - Zstd is 88% faster than XZ for decompression. - Zstd archive is 6% larger than XZ archive. All tests are done on an unix binary tarball generated by: ```sh ./koch.py unixrelease --format:tar ``` With this change we will be trading off a small amount of space for a massive improvement in compression and decompression time. <!-- ## Tips for pull requests * use chat, discussions, etc... to refine an idea for big and/or impactful changes * open them relatively early in draft mode and get regular feedback * add notes for reviewers and yourself as you go, so it's easy to maintain context * refine the pull request message over time --> <!-- ## Finalizing a PR: ### title: * reads like a short changelog line ### body: * describe the current behaviour * describe why this particular approach * if it's breaking, migration steps * note any follow-on work ### content: * leave code better than you found it, add docs, tests, etc --> <!-- * note any issues that this fixes entirely * use `fixes nim-lang#123 .` to auto-close issues --> Co-authored-by: Leorize <leorize+oss@disroot.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PDCurses wrapper will compile. However there are a couple dozen consts
commented out that were problematic, as they rely on const variables which Nimrod does not (yet) support. Also, I got confused about a few procs with function ptrs as arguments, so I commented them out. Feel free to fix