fixes nim-lang/nimsuggest#103 con dot exprs #16657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- con calls for dot exprs now returns results - discovered an issue with dot expr results -- documented
ardek66
pushed a commit
to ardek66/Nim
that referenced
this pull request
Mar 26, 2021
- con calls for dot exprs now returns results - discovered an issue with dot expr results -- documented
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dot exprs issue:
The way
conmatch works is to use a partial match, considering only the formal params after the call identifier. So dot exprs, overloads, etc aren't currently handled correctly. If you want to check out the code seesuggest.suggestCallwhich kicks things off, it'll end up usingsigmatch.partialMatchwhich leaves the heavy lifting tosigmatch.matchesAux.sigmatch.matchesAuxdoesn't use the operand before the dot as part of the formal parameters. Changing this is tricky because it's used by the proper compilation sem pass and that's a big change all in one go.