Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VM: 'nim e' etc, default to the VM's sandboxing behaviour #16943

Closed
wants to merge 1 commit into from

Conversation

Araq
Copy link
Member

@Araq Araq commented Feb 5, 2021

  • affects Nimble's Nimscript integration
  • New default is the sandboxed VM.
  • Use 'nim edanger' to run without the sandbox.

@timotheecour
Copy link
Member

timotheecour commented Feb 5, 2021

  • This is a breaking change, and should be rolled out more gradually by first introducing an optional sandbox instead, and only in future work (if needed) turning that sandbox into the default.

  • We should have a flag insted of a new command, it's more orthogonal (eg that vmsandox:on|off flag would be usable with all commands, including things like nim --eval, nim doc nim r nim e automatically). eg, a flag can be over-ridden on cmdline, but not a command, etc. Plus, naming is confusing (-d:danger has nothing to do with edanger un-sandboxing)

  • Note that we already have: --experimental:vmopsDanger with very similar intentions; why not reuse that, or, rather, use a similarly named one --experimental:vmsandbox which would be off by default for now, and in future work could be turned on (if needed)

EDIT: see also

@Araq
Copy link
Member Author

Araq commented Feb 5, 2021

Ok, well for now this was to see what it breaks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants