Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

type with same name in different scope now works #17710

Merged
merged 12 commits into from
Apr 14, 2021

Conversation

timotheecour
Copy link
Member

@timotheecour timotheecour commented Apr 13, 2021

unrelated question for reviewer

sighashes doesn't seem to do any caching, is that intentional?

future work

  • avoid (pre-existing) hacks to prevent endless recursion, and use caching via a hash table, which should also speed hashType (but we also need to assess whether hashType has some non-negligible cost)

tests/ccgbugs/tsame_name.nim Outdated Show resolved Hide resolved
@Araq Araq merged commit 840e13d into nim-lang:devel Apr 14, 2021
@timotheecour timotheecour deleted the exp_15526_cgen_ref branch April 14, 2021 06:52
PMunch pushed a commit to PMunch/Nim that referenced this pull request Mar 28, 2022
* type with same name in different scope now works
* fix tests/enum/tenum.nim which was wrong because it was affected by this bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants