-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make procedure mismatch more informative with pragma/call convention mismatches #18384
Conversation
Please add a test. |
Tests will be added, Timothee wanted the PR up so there could be some discussion to what this should contain, so after there is a agreement on what this should show/do and I implement it we'll get tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, the remaining comments are not critical and can be addressed in followup PR; great addition!
CI failure unrelated => SciNim/Datamancer#10 |
…mismatches (nim-lang#18384) * Added more concise calling convention/pragma mismatch messages * Now only adds callConvMsg/lock message when sensible * Fixed message formatting * Added tests, and fixed some bugs * Tests joined, and always indenting * More tests and more bug fixes * Fixed first test in tprocmismatch * Using var param for writting mismatches * Better logic for handling proc type rel and conv/pragma mismatch * Refactored getProcConvMismatch * Fixed callConv message formatting * Fixed test for proper message * Cleanup to address issues * getProcConvMismatch now returns tuple, and reformatted code
The following is a few showcases of the output changes
Examples:
Used to output:
Now outputs:
Used to output:
Now Outputs: