Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refs #16613: check opcWrDeref for nil #18613

Merged
merged 1 commit into from
Jul 30, 2021
Merged

refs #16613: check opcWrDeref for nil #18613

merged 1 commit into from
Jul 30, 2021

Conversation

timotheecour
Copy link
Member

@timotheecour timotheecour commented Jul 29, 2021 •
edited
Loading

refs #16613 /cc @yglukhov

before PR: SIGSEGV

after PR:

stack trace: (most recent call last)
/Users/timothee/git_clone/nim/temp/iface/tests/test1.nim(34, 23) test1
/Users/timothee/git_clone/nim/temp/iface/tests/test1.nim(24, 7) template/generic instantiation of `suite` from here
/Users/timothee/git_clone/nim/temp/iface/tests/test1.nim(34, 23) Error: opcWrDeref internal error

(so you at least got a stacktrace in user code instead of nothing with default nim)

see #16613 (comment) for more info, workaround and a proposal for a fix

@timotheecour timotheecour added the Ready For Review (please take another look): ready for next review round label Jul 30, 2021
@Araq Araq merged commit 9a26f50 into nim-lang:devel Jul 30, 2021
@timotheecour timotheecour deleted the pr_refs_16613_vm branch July 30, 2021 07:37
PMunch pushed a commit to PMunch/Nim that referenced this pull request Mar 28, 2022
@timotheecour @PMunch
refs nim-lang#16613: check opcWrDeref for nil (nim-lang#18613)
32ce493
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ringabout ringabout Awaiting requested review from ringabout

Assignees
No one assigned
Labels
Ready For Review (please take another look): ready for next review round
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timotheecour @Araq