Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #19297 - fixing broken list after adding empty list #19299

Merged
merged 3 commits into from
Dec 30, 2021
Merged

Fix #19297 - fixing broken list after adding empty list #19299

merged 3 commits into from
Dec 30, 2021

Commits on Dec 30, 2021

  1. Update lists.nim

    @rockcavera
    rockcavera committed Dec 30, 2021
    Configuration menu
    Copy the full SHA
    ae8b899 View commit details
    Browse the repository at this point in the history

  2. Update tlists.nim

    @rockcavera
    rockcavera committed Dec 30, 2021
    Configuration menu
    Copy the full SHA
    45a064a View commit details
    Browse the repository at this point in the history

  3. removed check if b.tail != nil 

    The tail of the list being null it is still possible to retrieve its end by going through all nodes from the head. So checking for null from `b.tail` is unnecessary. However, setting `a.tail = b.tail` only if `a.head != nil`, so you don't break a good list with an already broken one.
    @rockcavera
    rockcavera committed Dec 30, 2021
    Configuration menu
    Copy the full SHA
    9e8f4c1 View commit details
    Browse the repository at this point in the history