[Minor breaking] Allow named arguments in commands and streamline type expressions #19383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metagn
changed the title
Closed
metagn
commented
Jan 14, 2022
metagn
commented
Jan 14, 2022
metagn
commented
Jan 14, 2022
|
PR is pretty much done with some minor things listed above. Leaving it as draft until it's safe to merge breaking changes like this. |
|
It's hard to foresee the effects this has on existing code. I do like the changes though. But it's time to derive the parser from a formal grammar, we want to encourage alternative implementations and better editor plugins. |
|
What's the difference with normal PEG? Indents? |
|
Yes. |
metagn
changed the title
metagn
changed the title
|
Decided to unmark as draft considering how rarely breaking this is. Any choice is fine with me. |
metagn
force-pushed
the
parser-grammar
branch
3 times, most recently
from
6395a7c
to
d5dc3fb
Compare
Types are separated from expressions and better reflected in the grammar.
metagn
force-pushed
the
parser-grammar
branch
from
d5dc3fb
to
b51f21c
Compare
|
When will this be reviewed? |
|
Bump, this would be really nice to have before new parser PRs |
|
moved to #20994 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes nim-lang/RFCs#442, closes #15050, closes #8846 and maybe some other issues, cleans up after #19181, closes #19313.
Types are separated from normal expressions in the grammar.
object,tupleetc are special in type sections and cannot directly be used as expressions. This gives errors similar to #19313 for objects and tuples (which is reflected by the ordered choice in the grammar) and is fixed by wrapping in parentheses.refandptr(and alsodistinctbecause a package was usingdistinct object) are also special, but this is only whenobjectandtupleimmediately follow.foo a = bpreviously meantfoo(a) = b, now it meansfoo(a = b). This only applies to statement form expressions,exprStmtin the grammar, although this is not reflected in the grammar yet as it would be pretty complicated. Currently it uses a PrimaryMode enum field instead. Allowing this also resulted in line info of commands being more accurate, and commands now terminate on dedented commas which was not the case before.Both of these are (minorly) breaking. Changing code to make these work is very easy, however the second one will not give a direct syntax error upon being wrong and the first one gives errors that were not previously given. For this reason it can be delayed. #19191 and #19181 also had parser changes, but these added new syntax and were non-breaking.