Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compile pragma: cache the result sooner #19554

Merged
merged 1 commit into from
Feb 24, 2022
Merged

compile pragma: cache the result sooner #19554

merged 1 commit into from
Feb 24, 2022

Commits on Feb 22, 2022

  1. compile pragma: cache the result sooner 

    extccomp.addExternalFileToCompile() relies on hashes to decide whether
an external C file needs recompilation or not.

Due to short-circuit evaluation of boolean expressions, the procedure
that generates a corresponding hash file is not called the first time an
external file is compiled, so an avoidable recompilation is triggered
the next build.

This patch fixes that by moving the proc call with a desired side
effect from its boolean expression, so it's executed unconditionally.
    @stefantalpalaru
    stefantalpalaru committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    659f219 View commit details
    Browse the repository at this point in the history