Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused sfProcvar, "procvar" mentions #20204

Merged
merged 1 commit into from Aug 24, 2022
Merged

Conversation

metagn
Copy link
Collaborator

@metagn metagn commented Aug 11, 2022

refs #12975. doesn't close it because the procvar annotation isn't completely removed, just does nothing (packages like nimgame2 still use it)

refs nim-lang#12975. doesn't close it because wProcvar isn't removed
@Araq Araq merged commit d143924 into nim-lang:devel Aug 24, 2022
@github-actions
Copy link
Contributor

Thanks for your hard work on this PR!
The lines below are statistics of the Nim compiler built from d143924

Hint: mm: orc; threads: on; opt: speed; options: -d:release
163876 lines; 12.335s; 840.668MiB peakmem

foldl added a commit to foldl/nimDocTranslate that referenced this pull request Sep 8, 2022
1. 文字调整;
2. 删除 "so the `thread` pragma implies `procvar`"
  
   (PR nim-lang/Nim#20204) 
   这一句已不适用,不宜再翻译,按新版本删除。

Signed-off-by: Judd <foldl@outlook.com>
capocasa pushed a commit to capocasa/Nim that referenced this pull request Mar 31, 2023
refs nim-lang#12975. doesn't close it because wProcvar isn't removed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants