Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compute small nim string lit at CT #20439

Merged
merged 1 commit into from
Sep 27, 2022
Merged

Compute small nim string lit at CT #20439

merged 1 commit into from
Sep 27, 2022

Conversation

AmjadHD
Copy link
Contributor

@AmjadHD AmjadHD commented Sep 26, 2022

  • Reduces runtime overhead for small strings.
  • Avoids including makeNimstrLit in the output when all strings are small enough.

@AmjadHD
Compute small nim string lit at CT
d9b6fa5 
* Reduces runtime overhead for small strings.
* Avoids including `makeNimstrLit` in the output when all strings are
  small enough.
@Araq Araq merged commit d755c02 into nim-lang:devel Sep 27, 2022
@github-actions
Copy link
Contributor

Thanks for your hard work on this PR!
The lines below are statistics of the Nim compiler built from d755c02

Hint: mm: orc; threads: on; opt: speed; options: -d:release
164188 lines; 11.766s; 667.801MiB peakmem

@AmjadHD AmjadHD deleted the pr-js-ct-nim-str-lit branch September 27, 2022 12:42
capocasa pushed a commit to capocasa/Nim that referenced this pull request Mar 31, 2023
@AmjadHD @capocasa
Compute small nim string lit at CT (nim-lang#20439)
adcb79f 
* Reduces runtime overhead for small strings.
* Avoids including `makeNimstrLit` in the output when all strings are
  small enough.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AmjadHD @Araq