Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #20740; fixes pre-existing field visibility issues and removes efSkipFieldVisibilityCheck #20741

Merged
merged 1 commit into from Nov 3, 2022
Merged

fixes #20740; fixes pre-existing field visibility issues and removes efSkipFieldVisibilityCheck #20741

merged 1 commit into from Nov 3, 2022

Conversation

ringabout
Copy link
Member

@ringabout ringabout commented Nov 3, 2022 •
edited

fixes #20740
ref #20695

Probably I will rename it to nfSkipFieldVisibilityCheck later.

@ringabout ringabout changed the title fixes #20740 pre-existing field visibility and refactoring fixes #20740; fixes pre-existing field visibility issues and refactoring Nov 3, 2022
@ringabout ringabout changed the title fixes #20740; fixes pre-existing field visibility issues and refactoring fixes #20740; fixes pre-existing field visibility issues and does some refactoring Nov 3, 2022
@ringabout ringabout changed the title fixes #20740; fixes pre-existing field visibility issues and does some refactoring fixes #20740; fixes pre-existing field visibility issues and removes efSkipFieldVisibilityCheck Nov 3, 2022
@Araq
Copy link
Member

Araq commented Nov 3, 2022

Awesome patch!

@Araq Araq added the merge_when_passes_CI mergeable once green label Nov 3, 2022
@ringabout ringabout merged commit c4e5dab into devel Nov 3, 2022
@ringabout ringabout deleted the pr_field_check branch November 3, 2022 07:46
@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2022

Thanks for your hard work on this PR!
The lines below are statistics of the Nim compiler built from c4e5dab

Hint: mm: orc; opt: speed; options: -d:release
164616 lines; 8.632s; 613.918MiB peakmem

capocasa pushed a commit to capocasa/Nim that referenced this pull request Mar 31, 2023
@ringabout @capocasa
fixes nim-lang#20740; fixes pre-existing field visibility issues and …
3348f3d 
…removes `efSkipFieldVisibilityCheck` (nim-lang#20741)

fixes nim-lang#20740 pre-existing field visibility and refactoring
bung87 pushed a commit to bung87/Nim that referenced this pull request Jul 29, 2023
@ringabout @bung87
fixes nim-lang#20740; fixes pre-existing field visibility issues and …
2b8b5a9 
…removes `efSkipFieldVisibilityCheck` (nim-lang#20741)

fixes nim-lang#20740 pre-existing field visibility and refactoring
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merge_when_passes_CI mergeable once green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pre-existing field visibility of VM object passed to runtime
2 participants
@ringabout @Araq