Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #10938; fixes #13312; fixes #13918; fixes #20985; always initializes global variables with null values in VM #21351

Merged
merged 4 commits into from
Mar 1, 2023
Merged

fixes #10938; fixes #13312; fixes #13918; fixes #20985; always initializes global variables with null values in VM #21351

merged 4 commits into from
Mar 1, 2023

Conversation

ringabout
Copy link
Member

@ringabout ringabout commented Feb 11, 2023 •
edited
Loading

fixes #10938
fixes #13312
fixes #13918
fixes #20985
closes nim-lang/RFCs#276

There is a pre-existing issue, I don't feel like solving it in this PR

image

(var s: proc () = default(proc ()); doAssert s == nil)

@ringabout ringabout changed the title fixes #10938; fixes #13312; fixes #13918; fixes #20985; always initialize global variable in VM fixes #10938; fixes #13312; fixes #13918; fixes #20985; always initialize global variables with null values in VM Feb 11, 2023
@ringabout ringabout mentioned this pull request Feb 11, 2023
Closed
@ringabout ringabout changed the title fixes #10938; fixes #13312; fixes #13918; fixes #20985; always initialize global variables with null values in VM fixes #10938; fixes #13312; fixes #13918; fixes #20985; always initializes global variables with null values in VM Feb 11, 2023
@ringabout ringabout mentioned this pull request Feb 11, 2023
Open
@ringabout ringabout marked this pull request as ready for review February 13, 2023 14:16
@Varriount Varriount requested a review from Araq February 14, 2023 19:39
@Varriount Varriount added the Requires Araq To Merge PR should only be merged by Araq label Feb 14, 2023
@Araq Araq merged commit 1b1412f into devel Mar 1, 2023
@Araq Araq deleted the pr_vm_init branch March 1, 2023 16:18
@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2023

Thanks for your hard work on this PR!
The lines below are statistics of the Nim compiler built from 1b1412f

Hint: mm: orc; opt: speed; options: -d:release
166292 lines; 8.048s; 610.719MiB peakmem

@ringabout ringabout mentioned this pull request Mar 12, 2023
Merged
capocasa pushed a commit to capocasa/Nim that referenced this pull request Mar 31, 2023
@ringabout @capocasa
fixes nim-lang#10938; fixes nim-lang#13312; fixes nim-lang#13918; fixes
6f2ad1e 
nim-lang#20985; always initializes global variables with null values in VM (nim-lang#21351)

* fixes nim-lang#10938; always initialize global variable in VM

* fixes importc vars

* there is a pre-existing issue regarding closure types in the VM

* add tests
narimiran pushed a commit that referenced this pull request Apr 26, 2023
@ringabout @narimiran
fixes #10938; fixes #13312; fixes #13918; fixes #20985; always initia…
73d7159 
…lizes global variables with null values in VM (#21351)

* fixes #10938; always initialize global variable in VM

* fixes importc vars

* there is a pre-existing issue regarding closure types in the VM

* add tests

(cherry picked from commit 1b1412f)
narimiran pushed a commit that referenced this pull request Apr 26, 2023
@ringabout @narimiran
fixes #10938; fixes #13312; fixes #13918; fixes #20985; always initia…
7ceb4e4 
…lizes global variables with null values in VM (#21351)

* fixes #10938; always initialize global variable in VM

* fixes importc vars

* there is a pre-existing issue regarding closure types in the VM

* add tests

(cherry picked from commit 1b1412f)
bung87 pushed a commit to bung87/Nim that referenced this pull request Jul 29, 2023
@ringabout @bung87
fixes nim-lang#10938; fixes nim-lang#13312; fixes nim-lang#13918; fixes
da0be98 
nim-lang#20985; always initializes global variables with null values in VM (nim-lang#21351)

* fixes nim-lang#10938; always initialize global variable in VM

* fixes importc vars

* there is a pre-existing issue regarding closure types in the VM

* add tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Araq Araq Awaiting requested review from Araq

Assignees
No one assigned
Labels
Requires Araq To Merge PR should only be merged by Araq
Projects
None yet
Milestone
No milestone
3 participants
@ringabout @Araq @Varriount