fixes #22163; use {.push warning[BareExcept]:off.} to override settings temporarily
#21390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
try:..
except Exception as exc {.warning: [...].}`and/or {.warnig: [...].}:
try:
except ...would be nice to have |
ringabout
changed the title
{.push warning[BareExcept]:off.} to override settings temporarily{.push warning[BareExcept]:off.} to override settings temporarily
|
I'm merging it. It should fix #22163. It's used for when |
|
Thanks for your hard work on this PR! Hint: mm: orc; opt: speed; options: -d:release |
bung87
pushed a commit
to bung87/Nim
that referenced
this pull request
Jul 29, 2023
…ide settings temporarily (nim-lang#21390) * use `{.push warning[BareExcept]:off.}` to override settings temporarily * likewise, suppress expect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{.warning[BareExcept]:off.}works accidentally and might not continue to work in the future.ref #21390 (in fact, #21390 doesn't affect semantic options like
{.warning[BareExcept]:off.}, but it is misused here). In the futurepush pragmaswill continue to work reliably => #21388fixes #22163