fixes #21377; fixes @[] and {} type inference as returns in generics
#21475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ringabout
changed the title
@[] type inference in generics@[] and {} type inference in generics
ringabout
changed the title
@[] and {} type inference in generics@[] and {} type inference as returns in generics
|
Thanks for your hard work on this PR! Hint: mm: orc; opt: speed; options: -d:release |
capocasa
pushed a commit
to capocasa/Nim
that referenced
this pull request
Mar 31, 2023
…in generics (nim-lang#21475) * fixes `@[]` type inference in generics * add issue links * fixes macros and iterators * refactor * add one more test
narimiran
pushed a commit
that referenced
this pull request
May 11, 2023
bung87
pushed a commit
to bung87/Nim
that referenced
this pull request
Jul 29, 2023
…in generics (nim-lang#21475) * fixes `@[]` type inference in generics * add issue links * fixes macros and iterators * refactor * add one more test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #21377
The first cause is that
semProcBodyin instantiateBody didn't passexpectedTypeso it didn't work for empty sets. The second cause is that generic procs createnkStmtListExprs for values assigned to results. The type inference for assign is not enough. It can infer the type of the wholenkStmtListExpr, not the type of its lastSon. Finally I choose to infer the type directly for themArrToSeqmagic.