Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #19857; Exception raised in closure may be "skipped" in ORC #21530

Merged
merged 1 commit into from Mar 16, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions compiler/ccgcalls.nim
Expand Up @@ -475,6 +475,7 @@ proc genClosureCall(p: BProc, le, ri: PNode, d: var TLoc) =
discard "resetLoc(p, d)"
pl.add(addrLoc(p.config, d))
genCallPattern()
if canRaise: raiseExit(p)
else:
var tmp: TLoc
getTemp(p, typ[0], tmp, needsInit=true)
Expand Down
39 changes: 39 additions & 0 deletions tests/arc/tarcmisc.nim
Expand Up @@ -558,3 +558,42 @@ block:
doAssert y.id == 778
doAssert x[].id == 778
main()

block: # bug #19857
type
ValueKind = enum VNull, VFloat, VObject # need 3 elements. Cannot remove VNull or VObject

Value = object
case kind: ValueKind
of VFloat: fnum: float
of VObject: tab: Table[int, int] # OrderedTable[T, U] also makes it fail.
# "simpler" types also work though
else: discard # VNull can be like this, but VObject must be filled

# required. Pure proc works
FormulaNode = proc(c: OrderedTable[string, int]): Value

proc toF(v: Value): float =
doAssert v.kind == VFloat
case v.kind
of VFloat: result = v.fnum
else: discard


proc foo() =
let fuck = initOrderedTable[string, int]()
proc cb(fuck: OrderedTable[string, int]): Value =
# works:
#result = Value(kind: VFloat, fnum: fuck["field_that_does_not_exist"].float)
# broken:
discard "actuall runs!"
let t = fuck["field_that_does_not_exist"]
echo "never runs, but we crash after! ", t

doAssertRaises(KeyError):
let fn = FormulaNode(cb)
let v = fn(fuck)
#echo v
let res = v.toF()

foo()