Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes explicit deref block #22093

Merged
merged 1 commit into from
Jun 15, 2023
Merged

fixes explicit deref block #22093

merged 1 commit into from
Jun 15, 2023

Conversation

ringabout
Copy link
Member

@ringabout ringabout changed the title fixes explicit deref fixes explicit deref block Jun 14, 2023
@ringabout ringabout mentioned this pull request Jun 14, 2023
Merged
Araq
Araq reviewed Jun 14, 2023
View reviewed changes
compiler/transf.nim
of nkDerefExpr, nkHiddenDeref:
of nkDerefExpr:
result = transformAddrDeref(c, n, {nkAddr, nkHiddenAddr})
of nkHiddenDeref:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand this change. At this point there should be no difference between nkDerefExpr and nkHiddenDeref.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This transformation was done for lent's sake. I think it's safe not to transform nkDerefExpr. After all, the old change didn't transform it as well. It was me that introduced the extra transformation for nkDerefExpr.

image

ref b1fe169

Copy link
Member Author

@ringabout ringabout Jun 14, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least, it should be much better than before because the block transformation is not necessary for nkDerefExpr, but I can also investigate it further.

@ringabout ringabout closed this Jun 14, 2023
@ringabout ringabout reopened this Jun 14, 2023
@Araq Araq merged commit edb64bc into devel Jun 15, 2023
26 checks passed
@Araq Araq deleted the pr_re_deref branch June 15, 2023 07:56
@Araq
Copy link
Member

Araq commented Jun 15, 2023

Merging it because it improves the situation but we need to investigate further.

@github-actions
Copy link
Contributor

Thanks for your hard work on this PR!
The lines below are statistics of the Nim compiler built from edb64bc

Hint: mm: orc; opt: speed; options: -d:release
167872 lines; 9.128s; 611.012MiB peakmem

bung87 pushed a commit to bung87/Nim that referenced this pull request Jul 29, 2023
@ringabout @bung87
fixes explicit deref block (nim-lang#22093)
613f451 
fixes explicit deref
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Araq Araq Araq left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ringabout @Araq