Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #22173 sink paramers not moved into closure (refc) #22359

Merged
merged 2 commits into from
Aug 2, 2023
Merged

fix #22173 sink paramers not moved into closure (refc) #22359

merged 2 commits into from
Aug 2, 2023

Conversation

bung87
Copy link
Collaborator

@bung87 bung87 commented Aug 1, 2023 •
edited

fix #22173

@bung87 bung87 marked this pull request as draft August 1, 2023 19:52
@bung87 bung87 changed the title simply move without needToCopy flag fix #22173 sink paramers not moved into closure (refc) Aug 2, 2023
@bung87 bung87 marked this pull request as ready for review August 2, 2023 06:46
@Araq
Copy link
Member

Araq commented Aug 2, 2023

Please add a test case. Nice patch.

@Araq Araq merged commit b40da81 into nim-lang:devel Aug 2, 2023
16 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

Thanks for your hard work on this PR!
The lines below are statistics of the Nim compiler built from b40da81

Hint: mm: orc; opt: speed; options: -d:release
168417 lines; 9.474s; 613.043MiB peakmem

bung87 added a commit to bung87/Nim that referenced this pull request Aug 3, 2023
@bung87
subsequent of PR nim-lang#22359
dce16c9
@ringabout ringabout mentioned this pull request Aug 3, 2023
Closed
bung87 added a commit that referenced this pull request Aug 3, 2023
@bung87
Revert "fix #22173 sink paramers not moved into closure (refc) (#22359
98b8592 
)"

This reverts commit b40da81.
Araq pushed a commit that referenced this pull request Aug 3, 2023
@bung87
Revert "fix #22173 sink paramers not moved into closure (refc) (#22… (
6b913b4 
#22376)

Revert "fix #22173 `sink` paramers not moved into closure (refc) (#22359)"

This reverts commit b40da81.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sink paramers not moved into closure (refc)
2 participants
@bung87 @Araq