Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove some unnecessary initialization in seq operations #22677

Merged
merged 56 commits into from
Sep 10, 2023
Merged

Remove some unnecessary initialization in seq operations #22677

merged 56 commits into from
Sep 10, 2023

Conversation

AmjadHD
Copy link
Contributor

@AmjadHD AmjadHD commented Sep 9, 2023

  • PrepareSeqAdd
  • add
  • setLen
  • grow

Merge after #21842.

AmjadHD and others added 30 commits May 12, 2023 15:24
@AmjadHD
Make newSeqOfCap not initialize memory.
dcc0f12
@AmjadHD
Go seq
4454e0d
@AmjadHD
Merge branch 'devel' into fix-newSeqUninitialized
6d717cf
@AmjadHD
Merge branch 'devel' into fix-newSeqUninitialized
cb7db84
@AmjadHD
Merge branch 'devel' into fix-newSeqUninitialized
7396adb
@AmjadHD
Use =dup
3089ee1
@ringabout
Update lib/system/seqs_v2.nim
9ac1442
@ringabout
Update seqs_v2.nim
c527d6d
@AmjadHD
Merge branch 'devel' into fix-newSeqUninitialized
98d6219
@AmjadHD
Merge remote-tracking branch 'upstream/devel' into fix-newSeqUninitia…
e94759b 
…lized
@AmjadHD
Merge remote-tracking branch 'upstream/devel' into fix-newSeqUninitia…
5431925 
…lized
@AmjadHD
Merge remote-tracking branch 'upstream/devel' into fix-newSeqUninitia…
0a9711e 
…lized
@AmjadHD
Merge remote-tracking branch 'upstream/devel' into fix-newSeqUninitia…
b130eec 
…lized
@AmjadHD
Merge branch 'devel' into fix-newSeqUninitialized
e213b11
@AmjadHD
Merge branch 'devel' into fix-newSeqUninitialized
9e188bf
@ringabout
Merge branch 'devel' into fix-newSeqUninitialized
4a3a9dd
@AmjadHD
Merge branch 'devel' into fix-newSeqUninitialized
d286c47
@AmjadHD
Merge remote-tracking branch 'upstream/devel' into fix-newSeqUninitia…
b314bdb 
…lized
@AmjadHD
Merge remote-tracking branch 'upstream/devel' into fix-newSeqUninitia…
a318fde 
…lized
@AmjadHD
Merge branch 'devel' into fix-newSeqUninitialized
46a8a59
@AmjadHD
Merge remote-tracking branch 'upstream/devel' into fix-newSeqUninitia…
fb8c0de 
…lized
@AmjadHD
Merge remote-tracking branch 'upstream/devel' into fix-newSeqUninitia…
238ab88 
…lized
@AmjadHD
Merge remote-tracking branch 'upstream/devel' into fix-newSeqUninitia…
fed72d2 
…lized
@AmjadHD
Merge remote-tracking branch 'upstream/devel' into fix-newSeqUninitia…
8566e6f 
…lized
@AmjadHD
Merge remote-tracking branch 'upstream/devel' into fix-newSeqUninitia…
5964a17 
…lized
@AmjadHD
Merge remote-tracking branch 'upstream/devel' into fix-newSeqUninitia…
05427f9 
…lized
@AmjadHD
Use grow
432b9f7
@AmjadHD
Merge remote-tracking branch 'upstream/devel' into fix-newSeqUninitia…
3d9e995 
…lized
@AmjadHD
Merge remote-tracking branch 'upstream/devel' into fix-newSeqUninitia…
a3e9947 
…lized
@AmjadHD
Merge remote-tracking branch 'upstream/devel' into fix-newSeqUninitia…
8e3e692 
…lized
@AmjadHD AmjadHD marked this pull request as draft September 9, 2023 09:48
@AmjadHD AmjadHD closed this Sep 10, 2023
@AmjadHD AmjadHD reopened this Sep 10, 2023
@AmjadHD AmjadHD marked this pull request as ready for review September 10, 2023 13:21
@Araq Araq merged commit fbb5ac5 into nim-lang:devel Sep 10, 2023
19 checks passed
@github-actions
Copy link
Contributor

Thanks for your hard work on this PR!
The lines below are statistics of the Nim compiler built from fbb5ac5

Hint: mm: orc; opt: speed; options: -d:release
169801 lines; 8.275s; 620.082MiB peakmem

@AmjadHD AmjadHD deleted the remove-seq-init branch September 10, 2023 16:35
narimiran pushed a commit that referenced this pull request Sep 15, 2023
@AmjadHD @narimiran
Remove some unnecessary initialization in seq operations (#22677)
912757d 
* `PrepareSeqAdd`
* `add`
* `setLen`
* `grow`

Merge after #21842.

---------

Co-authored-by: ringabout <43030857+ringabout@users.noreply.github.com>
(cherry picked from commit fbb5ac5)
narimiran pushed a commit that referenced this pull request Sep 15, 2023
@AmjadHD @narimiran
Remove some unnecessary initialization in seq operations (#22677)
be93e67 
* `PrepareSeqAdd`
* `add`
* `setLen`
* `grow`

Merge after #21842.

---------

Co-authored-by: ringabout <43030857+ringabout@users.noreply.github.com>
(cherry picked from commit fbb5ac5)
narimiran pushed a commit that referenced this pull request Sep 15, 2023
@AmjadHD @narimiran
Remove some unnecessary initialization in seq operations (#22677)
187178a 
* `PrepareSeqAdd`
* `add`
* `setLen`
* `grow`

Merge after #21842.

---------

Co-authored-by: ringabout <43030857+ringabout@users.noreply.github.com>
(cherry picked from commit fbb5ac5)
narimiran pushed a commit that referenced this pull request Sep 15, 2023
@AmjadHD @narimiran
Remove some unnecessary initialization in seq operations (#22677)
bdf9bdc 
* `PrepareSeqAdd`
* `add`
* `setLen`
* `grow`

Merge after #21842.

---------

Co-authored-by: ringabout <43030857+ringabout@users.noreply.github.com>
(cherry picked from commit fbb5ac5)
narimiran pushed a commit that referenced this pull request Apr 17, 2024
@AmjadHD @narimiran
Remove some unnecessary initialization in seq operations (#22677)
3ddacd9 
* `PrepareSeqAdd`
* `add`
* `setLen`
* `grow`

Merge after #21842.

---------

Co-authored-by: ringabout <43030857+ringabout@users.noreply.github.com>
(cherry picked from commit fbb5ac5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AmjadHD @Araq @ringabout