Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

solution 3 for ambiguous on/off: dedicated enum #23124

Closed
wants to merge 4 commits into from
Closed

solution 3 for ambiguous on/off: dedicated enum #23124

wants to merge 4 commits into from

Conversation

metagn
Copy link
Collaborator

@metagn metagn commented Dec 23, 2023 •
edited
Loading

fixes #22841, fixes #23002, refs #23097

Mostly to test if anyone computes pragma options.

Edit: 1 package does

@metagn metagn mentioned this pull request Dec 25, 2023
Closed
@metagn
Copy link
Collaborator Author

metagn commented Dec 25, 2023

As written above this breaks 1 package which computes an arbitrary value for a pragma on/off, we could prevent this by just adding converter toOption*(x: bool): PragmaOption but that seems excessive for now. We could revisit this later down the line if more issues pop up (for now #23123 handles #22841 and #23002).

@metagn metagn closed this Dec 25, 2023
arnetheduck added a commit to status-im/nim-serialization that referenced this pull request Jan 2, 2024
@arnetheduck
symbol conflict workaround
4d541ec 
works around nim-lang/Nim#23124
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ambiguous identifier in pragma Unittest breaks if proc name on/off defined in same module
1 participant
@metagn