document the new ambiguous identifier resolution #23166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Araq
reviewed
Jan 5, 2024
doc/manual.md
Outdated
| the identifier has to be qualified unless it is an overloaded procedure or | ||
| iterator in which case the overloading resolution takes place: | ||
| If a module imports the same identifier from two different modules, the | ||
| identifier must be disambiguated in one of the following ways: |
There was a problem hiding this comment.
Good start, but the items 1, 2 are done by the compiler and 3 describes a way out for the programmer.
There was a problem hiding this comment.
I now (hopefully) phrased them all as ways out for the programmer, and moved qualification to the top
|
Better than before but not precise enough as it doesn't discuss how this works within generics etc. |
|
Thanks for your hard work on this PR! Hint: mm: orc; opt: speed; options: -d:release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #23123
Not sure if detailed enough.