Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #22852; fixes #23435; fixes #23645; SIGSEGV when slicing string or seq[T] with index out of range #23279

Merged
merged 3 commits into from
May 27, 2024
Merged

fixes #22852; fixes #23435; fixes #23645; SIGSEGV when slicing string or seq[T] with index out of range #23279

merged 3 commits into from
May 27, 2024

Conversation

ringabout
Copy link
Member

@ringabout ringabout commented Feb 5, 2024 •
edited
Loading

follow up #23013

fixes #22852
fixes #23435
fixes #23645

reports rangeDefect correctly

/workspaces/Nim/test9.nim(1) test9
/workspaces/Nim/lib/system/indices.nim(116) []
/workspaces/Nim/lib/system/fatal.nim(53) sysFatal
Error: unhandled exception: value out of range: -2 notin 0 .. 9223372036854775807 [RangeDefect]

@ringabout ringabout changed the title fixes #22852; SIGSEGV when slicing string or seq[T] with index out of… fixes #22852; SIGSEGV when slicing string or seq[T] with index out of range Feb 5, 2024
ringabout added a commit that referenced this pull request Mar 25, 2024
@ringabout
workaround #23435; real fix pending #23279
8ccaae7
@ringabout ringabout mentioned this pull request Mar 25, 2024
Merged
@ringabout ringabout changed the title fixes #22852; SIGSEGV when slicing string or seq[T] with index out of range fixes #22852; fixes #23435; SIGSEGV when slicing string or seq[T] with index out of range Mar 25, 2024
Araq pushed a commit that referenced this pull request Apr 18, 2024
@ringabout
workaround #23435; real fix pending #23279 (#23436)
229c125 
workaround #23435

related to #22852

see also #23279
@ringabout ringabout mentioned this pull request May 27, 2024
Closed
@ringabout ringabout changed the title fixes #22852; fixes #23435; SIGSEGV when slicing string or seq[T] with index out of range fixes #22852; fixes #23435; fixes #23645; SIGSEGV when slicing string or seq[T] with index out of range May 27, 2024
@Araq Araq added merge_when_passes_CI mergeable once green Showstopper labels May 27, 2024
@Araq Araq merged commit c615828 into devel May 27, 2024
22 checks passed
@Araq Araq deleted the pr_defect_range_check branch May 27, 2024 12:13
@github-actions GitHub Actions
Copy link
Contributor

Thanks for your hard work on this PR!
The lines below are statistics of the Nim compiler built from c615828

Hint: mm: orc; opt: speed; options: -d:release
178579 lines; 8.433s; 753.109MiB peakmem

ringabout added a commit that referenced this pull request May 27, 2024
@ringabout
Revert "workaround #23435; real fix pending #23279 (#23436)"
aebee68 
This reverts commit 229c125.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merge_when_passes_CI mergeable once green Showstopper
Projects
None yet
Milestone
No milestone
2 participants
@ringabout @Araq