Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #12340; If seq is the sink parameter, it can be changed from the function in refc #23360

Draft
wants to merge 10 commits into
base: devel
Choose a base branch
from
Draft

fixes #12340; If seq is the sink parameter, it can be changed from the function in refc #23360

wants to merge 10 commits into from
+15 −3

Conversation

ringabout
Copy link
Member

@ringabout ringabout commented Feb 29, 2024 •
edited
Loading

fixes #12340

more test cases pending #23359

@ringabout ringabout marked this pull request as draft March 1, 2024 14:46
@ringabout ringabout marked this pull request as ready for review March 13, 2024 14:45
@Araq
Copy link
Member

Araq commented May 10, 2024

Too adhoc. Why does this only apply to ref? What if I use sink (ref T, ref U) instead?

@ringabout ringabout marked this pull request as draft June 6, 2024 13:27
@ringabout ringabout closed this Jun 6, 2024
@ringabout ringabout reopened this Jun 6, 2024
@ringabout ringabout changed the title fixes #23354; fixes #12340; sink parameters sometimes not copied even when there are later reads fixes #12340; sink parameters sometimes not copied even when there are later reads Jun 6, 2024
@ringabout ringabout changed the title fixes #12340; sink parameters sometimes not copied even when there are later reads fixes #12340; If seq is the sink parameter, it can be changed from the function Jun 6, 2024
@ringabout ringabout changed the title fixes #12340; If seq is the sink parameter, it can be changed from the function fixes #12340; If seq is the sink parameter, it can be changed from the function in refc Jun 6, 2024
ringabout
ringabout commented Jun 7, 2024
View reviewed changes
compiler/sempass2.nim Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

If seq is the sink parameter, it can be changed from the function
2 participants
@ringabout @Araq