Converted the 'invalid kind for firstOrd/lastOrd(XXX)' messages from internal errors to fatal errors. #23443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m internal
errors to fatal errors. This fixes a nimsuggest crash when opening:
beacon_chain/consensus_object_pools/blockchain_dag.nim
from the nimbus-eth2 project and many other .nim files (44 files, to be
precise) in the same project.
|
Thanks for your hard work on this PR! Hint: mm: orc; opt: speed; options: -d:release |
nickysn
added a commit
to nickysn/Nim
that referenced
this pull request
Mar 27, 2024
…internal errors to fatal errors. (nim-lang#23443) This fixes a nimsuggest crash when opening: beacon_chain/consensus_object_pools/blockchain_dag.nim from the nimbus-eth2 project and many other .nim files (44 files, to be precise) in the same project. Replaces: nim-lang#23402 (cherry picked from commit c934d59)
nickysn
added a commit
to nickysn/Nim
that referenced
this pull request
Mar 27, 2024
…internal errors to fatal errors. (nim-lang#23443) This fixes a nimsuggest crash when opening: beacon_chain/consensus_object_pools/blockchain_dag.nim from the nimbus-eth2 project and many other .nim files (44 files, to be precise) in the same project. Replaces: nim-lang#23402 (cherry picked from commit c934d59)
Araq
pushed a commit
that referenced
this pull request
Mar 27, 2024
…' messages from internal errors to fatal errors. (#23443) (#23446) This fixes a nimsuggest crash when opening: beacon_chain/consensus_object_pools/blockchain_dag.nim from the nimbus-eth2 project and many other .nim files (44 files, to be precise) in the same project. Replaces: #23402 (cherry picked from commit c934d59)
Araq
pushed a commit
that referenced
this pull request
Apr 6, 2024
…internal errors to fatal errors. (#23443) (#23447) This fixes a nimsuggest crash when opening: beacon_chain/consensus_object_pools/blockchain_dag.nim from the nimbus-eth2 project and many other .nim files (44 files, to be precise) in the same project. Replaces: #23402 (cherry picked from commit c934d59)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a nimsuggest crash when opening:
beacon_chain/consensus_object_pools/blockchain_dag.nim
from the nimbus-eth2 project and many other .nim files (44 files, to be precise) in the same project.
Replaces: #23402