[backport] fixes #23748; do not skip materializing temporaries for proc arguments

[alex65536]

fixes #23748

[Araq]

Superb work, but this fails: tests/destructor/t23748.nim cpp --gc:arc

[alex65536]

Superb work, but this fails: tests/destructor/t23748.nim cpp --gc:arc

Thanks, fixed :)

Though, fixing the issue for C++ was a bit more tough than for C.

[alex65536]

Oops, seems that I've broken something else trying to fix it :(

[alex65536]

It seems to pass the tests better, but I think that the current solution with setting tfVarIsPtr back and forth is quite hacky, so I want to look up for another solution.

[Araq]

Unfortunately tests are still red.

[alex65536]

It seems that tests fail just because http://example.com/404 returns error 500 instead of 404:

$ curl -v http://example.com/404 |& grep 'HTTP/1.1'
> GET /404 HTTP/1.1
< HTTP/1.1 500 Internal Server Error

The same test also fails in devel. I am going to comment it out.

[alex65536]

Made a separate PR to fix the flaky test: #23772.

[alex65536]

It seems that the rest of the failing tests are flaky (with Permission denied from linker under Windows) and not related to the actual change.

@Araq could you please take a look?

[alex65536]

(probably we should also merge #23772 before this)

[alex65536]

All the tests pass now, could you please merge this?

[Araq]

Sure, sorry that it took me one hour on a Sunday to respond. ;-)

[github-actions]

Thanks for your hard work on this PR!
The lines below are statistics of the Nim compiler built from 4202b60

Hint: mm: orc; opt: speed; options: -d:release
179041 lines; 8.393s; 664.703MiB peakmem

[narimiran]

@alex65536 I've seen that you marked this PR with [backport]. When I tried to backport it to the version-2-0, it produced errors with cpp backend: example of a failing CI

If you're willing, you could investigate why it is happening, i.e. if some previous devel commit also needs to be backported or maybe you can fix it in another way.

If you want to test it locally (with version-2-0 + your fix from this PR), you can run: koch temp cpp --mm:refc tests/stdlib/trepr.nim to reproduce the error reported by CIs.

[alex65536]

@narimiran it seems that the test referenced by you passes successfully if you also backport the following commit: f7c6e04.

Let me know if there are other issues with backporting this fix.

[narimiran]

@narimiran it seems that the test referenced by you passes successfully if you also backport the following commit: f7c6e04.

Let me know if there are other issues with backporting this fix.

Great find, thanks!

Now I've backported both this PR and that commit.