Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use monotonic timestamp to calculate timeouts refs #23826 #23834

Merged
merged 2 commits into from
Jul 15, 2024
Merged

Use monotonic timestamp to calculate timeouts refs #23826 #23834

merged 2 commits into from
Jul 15, 2024

Conversation

maleyva1
Copy link
Contributor

Related to #23826. This address issues raised here by using a monotonic timestamp to calculate timeouts and increasing the max sleep time to 50ms.

@maleyva1 maleyva1 mentioned this pull request Jul 13, 2024
Merged
alex65536
alex65536 reviewed Jul 13, 2024
View reviewed changes
lib/pure/osproc.nim Outdated Show resolved Hide resolved
alex65536
alex65536 reviewed Jul 13, 2024
View reviewed changes
lib/pure/osproc.nim Outdated Show resolved Hide resolved
@Araq Araq merged commit a5186a9 into nim-lang:devel Jul 15, 2024
18 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Thanks for your hard work on this PR!
The lines below are statistics of the Nim compiler built from a5186a9

Hint: mm: orc; opt: speed; options: -d:release
173136 lines; 8.201s; 664.164MiB peakmem

This was referenced Jul 16, 2024
Closed
Merged
narimiran pushed a commit that referenced this pull request Jul 17, 2024
@ringabout
fixes #23844; Nim devel nightly i386 build failing (#23849)
9de74b7 
fixes #23844
follow up #23834

```nim
type
  Timespec* {.importc: "struct timespec",
               header: "<time.h>", final, pure.} = object ## struct timespec
    tv_sec*: Time  ## Seconds.
    tv_nsec*: clong  ## Nanoseconds.
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Araq Araq Araq left review comments

@alex65536 alex65536 alex65536 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@maleyva1 @Araq @alex65536