Added heapqueue collection. Fixed timers in asyncdispatch. #4122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you made any benchmarks on your timers? |
|
@cheatfate, I can't see what to benchmark here. My small private tool that relies on intensive polling (check and sleep with adaptive (close to zero) timeout) shows 600 polls/sec, instead of 2-3 polls/sec as it was before the fix. Timer addition takes log n instead of 1, and timers processing is log n (close to 1 in reality) instead of n, timeout adjustment before polling (new functionality that fixes this bug) is 1. Basically this PR fixes a logic bug, it's not intended to change overall performance really. |
| # heap invariant. | ||
| proc siftdown[T](heap: var HeapQueue[T], startpos, p: int) = | ||
| var pos = p | ||
| var newitem = heap[pos] |
There was a problem hiding this comment.
system.shallowCopy is faster than '=' for these things usually, where data is only moved around internally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4120