VCC wrappers with vcvars args. #4949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VCC wrappers no longer wrap for compile-time specific target VCC wrappers now peek into the command line args and evaluate vcvars prefixed arguments
fredrikhr
commented
Oct 24, 2016
| vcc.exe = "vccexe.exe" | ||
| vcc.linkerexe = "vccexe.exe" | ||
|
|
||
| # Here we need to set the options for specific platforms: |
There was a problem hiding this comment.
@Araq I'm unsure if this is how we would do this?
fredrikhr
commented
Oct 24, 2016
| vcc.options.debug = "/Zi /Fd\"$projectName.pdb\"" | ||
| vcc.options.always = "/nologo" | ||
| vcc.options.speed = "/O2 /arch:SSE2" |
There was a problem hiding this comment.
My CL.exe (Microsoft (R) C/C++ Optimizing Compiler Version 19.00.24215.1) complains abount /arch:SSE2
Link.exe wrapper superfluous, because Nim uses cl.exe command-line arguments to defer to linker
Araq
reviewed
Oct 25, 2016
| vcc.options.debug = "/Zi /Fd\"$projectName.pdb\"" | ||
| vcc.options.always = "/nologo" | ||
| @if defined(i386): |
Araq
reviewed
Oct 25, 2016
| platformArgPrefix = "platform:" | ||
| storeArgPrefix = "store" | ||
| sdkArgPrefix = "sdk:" | ||
| vcvarsArgIdx = 1 # vcvars comes after - or / char in argument |
There was a problem hiding this comment.
This is convoluted. The arguments should be like --foo:var like Nim does. This way there is also no clash possible with cl's arguments.
Not necessary, since vccexe uses less advanced, but non-invasive argument parsing
previous options.linker.always is not supported in nim.cfg Removed /Fd\"$projectName.pdb\" (Implied by /Zi)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VCC wrappers no longer wrap for compile-time specific target, instead they now peek into the command line args and evaluate vcvars prefixed arguments