Proper fix for osproc.nim on Android

[cheatfate]

Fix sigtimedwait to use direct syscall to __NR_rt_sigtimedwait (available since Android SDK L3).

Testing needed...

[ghost]

yay, I can test this. What do I need to install Nim in Termux fully from scratch (I have Termux installed)? I have Android 6.0

[stisa]

@cheatfate just tested this, thanks a lot!
I get a type mismatch when doing koch boot:
Error: type mismatch: got (clong) but expected 'cint = int32'

Changing the return type of syscall from clong to cint seems to "fix" it, and I can do koch boot fine.

@TiberiumN : my steps (android 7, 64bit) :

apt install git
apt install clang
git clone https://github.com/cheatfate/Nim -b android_stwait
cd Nim && git clone https://github.com/nim-lang/csources
apt install libandroid-glob && apt install libandroid-glob-dev

In csources/build.sh line 32: LINK_FLAGS="${LDFLAGS:-} -landroid-glob "

In whatever c_source/#_# ( mine was 2_2 , I think it's 2_2 for 64bit and 2_1 for 32bit ) folder it's building, in stdlib_osproc.c change "bin/sh" to "sh" (line 400)
now in csources, sh ./build.sh should work and bootstraps nim.
To build devel then:
In config/nim.cfg add passL=" -landroid-glob " and define:android
In lib/posix/posix.nim : line 283: when defined(macosx) or defined(android): and on line 1623: when not defined(macosx) and not defined(android) ( you just need to add the android part )
In lib/pure/osproc.nim "bin/sh" -> "sh" (line 744 )
Now ./bin/nim c koch should work, and we can build nim

./koch boot

Nimble may have some problems, I remember libman saying he had to patch getTempDir to use the termux specific folder or something.

I'll look into adding support in platform.nim so that we can have csources for android too.

[ghost]

@stisa
it fails for me on ./bin/nim c koch:
"lib/posix/posix.nim(2430, 21) Error: type mismatch: got (clong) but expected 'cint = int32' "

My phone is 64bit, Termux reports aarch64

[stisa]

@TiberiumN I did write about it:

I get a type mismatch when doing koch boot:
Error: type mismatch: got (clong) but expected 'cint = int32'

Changing the return type of syscall from clong to cint seems to "fix" it, and I can do koch boot fine.

[ghost]

@stisa ah, sorry :)

[ghost]

@stisa so I can confirm:
Xiaomi Redmi 4 Pro, Android 6.0.1, MIUI 8.2 Global
Works with your steps

[ghost]

@stisa
and same error for nimble- Read-only file system

[cheatfate]

@stisa i know that this fix will allow you to bootstrap Nim, but please test this function:

import osproc

proc waitForExit(p: Process, timeout: int = -1): int

with timeout > 0.

This function was affected by this fix, and i want to be sure it still working...

[stisa]

@cheatfate You are right, it doesn't work (btw the compiler still complains that you return a clong from syscall and it expects a cint as result in sigtimedwait ).
If I change the return type of syscall to cint, it compiles but sigtimedwait returns -1, which I guess is to be expected when randomly changing return types?

[cheatfate]

@stisa please check this one.

[stisa]

Nope, still -1 and oserror. I tried printing NR_rt_sigtimedwait.cint , it outputs 137 , which looking here is correct. errno is 22, which should translate to EINVAL .

[cheatfate]

EINVAL is a problem...

[cheatfate]

Ok i think final fix must work, i have tested it on Linux with -d:android and it works, so i think it will work on Android too.

[stisa]

This one works for me, great work @cheatfate! Thanks a lot.

code used as a test:

import osproc
var p = startProcess("/data/data/com.termux/files/usr/bin/ping", 
                      args=["-c","2","google.com"], options={poParentStreams})

echo p.waitForExit(3333)