[JSON] getBVal -> getBool; getFNum -> getFloat; getNum -> getBiggestInt; add getInt #6504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yardanico
changed the title
dom96
requested changes
Oct 14, 2017
| @@ -47,7 +47,7 @@ proc createLoadProc(typeName: NimIdent, identDefs: seq[NimNode]): NimNode = | |||
| `cfgIdent`.`fieldNameIdent` = `objIdent`[`fieldName`].getStr | |||
| of "int": | |||
| body.add quote do: | |||
| `cfgIdent`.`fieldNameIdent` = `objIdent`[`fieldName`].getNum().int | |||
There was a problem hiding this comment.
Please don't change this. We need to make sure that whatever is in the book continues to work. That's the whole point.
web/bountysource.nim
Outdated
| @@ -53,7 +53,7 @@ proc processSupporters(supporters: JsonNode) = | |||
| echo("Found ", supporters.elems.len, " named sponsors.") | |||
There was a problem hiding this comment.
Just remove this file please, it lives in the website repo now.
|
So how about the fields of JsonNode?? Their named str, num, fnum, bval and are exported. I would ask to revert this. |
|
@konqoro generally fields of JsonNode shouldn't be used directly. |
|
ok @Yardanico how about properly deprecating these procs without removing them? This change breaks a lot of code out there for no reason. |
|
@konqoro check the code please, I've deprecated old proc names |
|
@Yardanico no you didn't code does not compile |
|
@konqoro are you sure? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed procedure names, so they make more sense now.
Old procedure names are now deprecated.
Also removed bountysource, since it lives in the website repo.