Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose nimGC_setStackBottom #7885

Merged
merged 1 commit into from
Jun 4, 2018
Merged

Conversation

yglukhov
Copy link
Member

No description provided.

@Araq
Copy link
Member

Araq commented May 29, 2018

Shouldn't this be renamed to nimGC_setStackBottom? It's for C clients, after all.

@yglukhov
Copy link
Member Author

ok

@yglukhov yglukhov changed the title Expose GC_setStackBottom Expose nimGC_setStackBottom May 29, 2018
@yglukhov
Copy link
Member Author

Good to go now?

@andreaferretti
Copy link
Collaborator

@Araq There is a bug in Pynim whose fix depends on this PR. I can use a custom Nim compiler which includes this, but if there is nothing wrong, would it be possible to merge it?

@Araq Araq merged commit 395b750 into nim-lang:devel Jun 4, 2018
@yglukhov yglukhov deleted the GC_setStackBottom branch June 4, 2018 09:15
@andreaferretti
Copy link
Collaborator

Great, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants