Fixed Travis CI for macOS #7962
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 7, 2018 21:02
|
This seems to work, macOS build on travis works now |
|
Travis failed because I cancelled linux build (to not waste time), and not all tests passed on macOS. |
ghost
changed the title
|
What does this do? And why is it required for macOS? Maybe you could look into why the tests fail on macOS too? |
|
@dom96 This PR fixes building Nim on Travis with macOS (so it can at least run tests now). |
|
@dom96 as you can see in current macOS builds on travis it just fails before Nim compilation: https://travis-ci.org/nim-lang/Nim/jobs/389173091 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.