Testament should run tests with no action #8232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 7, 2018
Varriount
requested changes
Jul 9, 2018
| @@ -16,6 +16,5 @@ proc main = | |||
| var leaf = "this is the leaf. it allocates" | |||
| let x = createCycle(leaf) | |||
| let y = createCycle(leaf) | |||
| echo "done ", getOccupiedMem() | |||
There was a problem hiding this comment.
cyclecollector.nim was never run before, only compiled. If you run it without an output check, test will fail since it does print something, so I removed the output altogether. getOccupiedMem() can vary by system so there's no guaranteed output to check against. Just printing done is pointless, return value check is sufficient.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Started with #5626 where test was never run, only compiled, since no action, output or exitCode check was defined in test case.
Per discussion on IRC, decision to make testament run tests if no action specified.
Fixed a few test cases which now break since they never ran before. Please review to confirm I made the right assumptions.
Also opened #8231 and commented out that test case until it gets fixed.