Support only some types as JsAssoc keys, fix #8601 #8627
Conversation
alehander92
force-pushed
the
fix-js-assoc
branch
from
a580f95
to
3e62fe5
Compare
|
One can still support any type as a key, if he adds a function for it that matches the concept. |
|
I don't like it. |
|
I don't agree, it's straightforward to support integers/enums(as far as I understand, floats too) in a type safe way and there is one obvious way to convert them: if JsAssoc doesn't support that, everyone will just write their own custom incompatible JsAssoc alternative (I would). The problem with other types is that there isn't an obvious way to map it correctly, so it doesn't make sense to provide a stdlib default. I thought concepts are already fine for the stdlib? |
lib/js/jsffi.nim
Outdated
| @@ -69,10 +69,25 @@ template mangleJsName(name: cstring): cstring = | |||
| inc nameCounter | |||
| "mangledName" & $nameCounter | |||
|
|
|||
| # only values that can be mapped 1 to 1 with cstring should be keys: they have an injective function with cstring | |||
|
|
|||
| proc injectiveTo*[T: SomeInteger](text: cstring, t: type T): T {.importcpp: "parseInt(#)".} | |||
lib/js/jsffi.nim
Outdated
| type | ||
| JsInjective* = concept a, type T |
lib/js/jsffi.nim
Outdated
| {. importcpp: setImpl .} | ||
| ## Set the value of a property of name `field` in a JsAssoc `obj` to `v`. | ||
|
|
||
| proc `[]=`*[V](obj: JsAssoc[string, V], field: cstring, val: V) |
There was a problem hiding this comment.
Why was it written this way? JsAssoc only works with cstring, not with string.
alehander92
force-pushed
the
fix-js-assoc
branch
from
3e62fe5
to
82ac397
Compare
alehander92
force-pushed
the
fix-js-assoc
branch
from
82ac397
to
5d4d587
Compare
|
unrelated fail, comment addressed |
We limit JsAssoc keys to types with values that can be mapped 1 to 1 with cstring .
Drop the support for
JsAssoc[string, V]. Still, one can doJsAssoc[cstring, string]{a: "e", "b": "e"}and access cstring keys with string literals.Convert keys automatically in iterators