fix #8341: add lastPathPart #9116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timotheecour
force-pushed
the
pr_baseName
branch
from
d9465a3
to
a66affe
Compare
This was referenced Oct 9, 2018
krux02
pushed a commit
to krux02/Nim
that referenced
this pull request
Oct 15, 2018
narimiran
pushed a commit
to narimiran/Nim
that referenced
this pull request
Oct 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @Araq
extractFilename("usr/lib/")should return "lib" (not "") and be calledbaseName(since works with dirs) #8341lastPathPartthat is similar to extractFilename but ignores trailing dir separator, to get behavior found in:unix cmd line, C, D, node.js
Note: pathSuffix would be another naming option...