-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dips, nimble file handling, and gitops #120
base: master
Are you sure you want to change the base?
Conversation
7bba972
to
65630b3
Compare
This PR started to work on nim-lang#117 but uncovered a few other items which needed cleaned up or fixed. Changes: Combine multiple ways to search for Nimble files into one place fixes some edge cases in handling finding Nimble files fixes issue with writing default config file and handling the deps cli option osutils.nim provides shims for unit testing proc's using a subset of file operations unit tests for various nimble file states unit tests for parsing PkgUrl's fixes some adhoc git execs to use the gitops module, restoring logging etc
b76d86e
to
4882b25
Compare
@Araq fixed this PR. I started tracking down another set of issues and got a broken commit mixed in here. |
type
NimbleFile = object
results: int
file: string # only valid if results == 1
|
Don't error on ambiguous nimble files
Co-authored-by: Andreas Rumpf <rumpf_a@web.de>
It does introducing another possible error state, but that can be handled by ensuring the code that finds the nimble files doesn't return Mainly I found it useful in documenting elsewhere in the codebase that the Nimble file might not be found yet and that using |
This PR started to work on #117 but uncovered a few other items which needed cleaned up or fixed.
Changes: