Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise require nim version of checksums to 2.0? #13

Closed
PhilippMDoerner opened this issue Dec 21, 2023 · 1 comment · Fixed by #14
Closed

Raise require nim version of checksums to 2.0? #13

PhilippMDoerner opened this issue Dec 21, 2023 · 1 comment · Fixed by #14

Comments

@PhilippMDoerner
Copy link
Contributor

Heyho, the nimble version of this package currently states: requires "nim >= 1.6.12"

Is this actually correct?

Mostly asking because the following does not compile:

import checksums/bcrypt
import std/sysrand

proc hash(pw: string): string =
  let salt = urandom(16)
  let hash = bcrypt(pw, generateSalt(12))
  return $hash

echo hash("lala")
/home/philipp/.nimble/pkgs2/checksums-0.1.0-5da023bd508223aa026ccd5fc3a75177f111226b/checksums/bcrypt.nim(464, 47) Error: expression has no address; maybe use 'unsafeAddr'

Which makes me assume it's not covered by the test suite, thus making me assume 1.6.12 may not actually be supported 😄

@ringabout
Copy link
Member

ringabout commented Dec 22, 2023

Make sense, it should be bumped to 2.0

PhilippMDoerner added a commit to PhilippMDoerner/checksums that referenced this issue Dec 27, 2023
ringabout pushed a commit that referenced this issue Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants