Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily remove outdated package list URL that was serving stale data #1141

Merged
merged 3 commits into from
Sep 6, 2023
Merged

Temporarily remove outdated package list URL that was serving stale data #1141

merged 3 commits into from
Sep 6, 2023

Conversation

xTrayambak
Copy link
Contributor

  • remove outdated nimble package files

See #1139 and #1129 for more details.

@Araq Araq merged commit a6c07be into nim-lang:master Sep 6, 2023
6 checks passed
@@ -23,8 +23,13 @@ proc initConfig(): Config =
result.chcp = true
result.cloneUsingHttps = true
result.packageLists["official"] = PackageList(name: "Official", urls: @[
"https://raw.githubusercontent.com/nim-lang/packages/master/packages.json",
"https://nim-lang.org/nimble/packages.json"
Copy link
Member

@ringabout ringabout Sep 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though I would appreciate that "https://nim-lang.org/nimble/packages.json" is updated, which would greatly improve my user experience. raw.githubusercontent.com sucks because of my SSL settings.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. GitHub sometimes stops working for me as well.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also appreciate having "https://nim-lang.org/nimble/packages.json" as a fallback option because my connection to that github domain can be unreliable sometimes.

Araq pushed a commit to nim-lang/Nim that referenced this pull request Oct 11, 2023
Issues like nim-lang/nimble#1149 keep popping
up. One way or another, we should alleviate the pain.

Finally, we should consider
nim-lang/nimble#1141 (comment) as
an option using some kind of cron script to update
https://nim-lang.org/nimble/packages.json. It's turning into a really
annoying problem.
@xTrayambak
Copy link
Contributor Author

Shoot, I was counting each line like a package. Nope, 26K packages were NOT indeed gone, the number is probably smaller, but still significant.

@ringabout
Copy link
Member

ringabout commented Nov 15, 2023

@xTrayambak Hello, with the great help of @PMunch, https://nim-lang.org/nimble/packages.json is up to date (853 kb now)! Eventually, there will be a script to update it automatically. It would be appreciated if you could add the URL back.

@xTrayambak
Copy link
Contributor Author

That's great to hear! I'll work on it tomorrow if that's fine.

@ringabout
Copy link
Member

No problem, thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants