-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temporarily remove outdated package list URL that was serving stale data #1141
Conversation
@@ -23,8 +23,13 @@ proc initConfig(): Config = | |||
result.chcp = true | |||
result.cloneUsingHttps = true | |||
result.packageLists["official"] = PackageList(name: "Official", urls: @[ | |||
"https://raw.githubusercontent.com/nim-lang/packages/master/packages.json", | |||
"https://nim-lang.org/nimble/packages.json" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Though I would appreciate that "https://nim-lang.org/nimble/packages.json" is updated, which would greatly improve my user experience. raw.githubusercontent.com
sucks because of my SSL settings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep. GitHub sometimes stops working for me as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would also appreciate having "https://nim-lang.org/nimble/packages.json" as a fallback option because my connection to that github domain can be unreliable sometimes.
Issues like nim-lang/nimble#1149 keep popping up. One way or another, we should alleviate the pain. Finally, we should consider nim-lang/nimble#1141 (comment) as an option using some kind of cron script to update https://nim-lang.org/nimble/packages.json. It's turning into a really annoying problem.
Shoot, I was counting each line like a package. Nope, 26K packages were NOT indeed gone, the number is probably smaller, but still significant. |
@xTrayambak Hello, with the great help of @PMunch, https://nim-lang.org/nimble/packages.json is up to date (853 kb now)! Eventually, there will be a script to update it automatically. It would be appreciated if you could add the URL back. |
That's great to hear! I'll work on it tomorrow if that's fine. |
No problem, thank you very much! |
See #1139 and #1129 for more details.