Choose USER-specific tmpdir #656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dom96
requested changes
May 26, 2019
There was a problem hiding this comment.
IMO Nim's getTempDir should be fixed to use $TMPDIR. We can work around it here for now but in the long run I don't want to have code that works around the stdlib's bugs, the stdlib should be fixed.
Anyway, thanks for creating this PR. We need a different getNimbleTempDir though, one which doesn't create a directory based on the PID.
src/nimblepkg/nimscriptsupport.nim
Outdated
| @@ -382,7 +382,7 @@ proc execScript(scriptName: string, flags: Flags, options: Options): PSym = | |||
|
|
|||
| # Ensure that "nimblepkg/nimscriptapi" is in the PATH. | |||
| block: | |||
| let t = getTempDir() / "nimblecache" | |||
| let t = getNimbleTempDir() / "nimblecache" | |||
There was a problem hiding this comment.
This defeats the purpose of the cache, getNimbleTempDir will return a different directory for each Nimble invokation...
|
I would change this to:
But this will do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re: #80
The question is what to do on Windows. Here, we check for
$USERin the environment, and use it iff set.The other question is how to find
/tmp. It's more common to check$TMPDIRon Linux and OSX, andgetTempDir()is discouraged in Nim.This will use
$TMPDIR/$USER/nimble-$PID/nimblecacheif possible, andgetTempDir()/nimble-$PID/nimblecacheotherwise. That way current behavior can (almost) be maintained on systems which lack USER or TMPDIR, but people have ways around this when needed.