Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show cmd used with --verbose (even on success); fix #783 #781

Merged
merged 9 commits into from
Mar 26, 2020

Conversation

timotheecour
Copy link
Member

@timotheecour timotheecour commented Mar 15, 2020

before PR:
nimble install -y -p:-u:release https://github.com/genotrance/nimgen
doesn't show the actual command used and instead shows the un-informative:
Building nimgen/nimgen.exe using c backend
even with --verbose

after PR:
shows the actual cmd used with --verbose, eg:

cmd /Users/timothee/.nimble/bin/nim c --noNimblePath -d:NimblePkgVersion=0.5.1 -u:release -d:release --path:"/Users/timothee/.nimble/pkgs/c2nim-0.9.14"  --path:"/Users/timothee/git_clone/nim/nim-regex/src"  --path:"/Users/timothee/git_clone/nim/nim-unicodedb/src"  --path:"/Users/timothee/.nimble/pkgs/unicodeplus-0.5.1"  --path:"/Users/timothee/git_clone/nim/nim-unicodedb/src"  -o:"/var/folders/ll/dtd6ksrn50n3xkdy4y61tf_80000gn/T/nimble_16626/githubcom_genotrancenimgen/nimgen" /var/folders/ll/dtd6ksrn50n3xkdy4y61tf_80000gn/T/nimble_16626/githubcom_genotrancenimgen/src/nimgen.nim

example

nim c -o:nimble2 src/nimble.nim
./nimble2 install -y https://github.com/genotrance/nimgen
./nimble2 install -y -p:-u:release --verbose https://github.com/genotrance/nimgen
(or ./nimble2 install -y -p:-u:release --verbose https://github.com/genotrance/nimgen to verify the other change I did)

src/nimble.nim Outdated Show resolved Hide resolved
@timotheecour
Copy link
Member Author

PTAL

Copy link
Collaborator

@dom96 dom96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests need to be fixed as well, are they flaky?

src/nimble.nim Show resolved Hide resolved
@timotheecour timotheecour mentioned this pull request Mar 18, 2020
@timotheecour
Copy link
Member Author

timotheecour commented Mar 18, 2020

PTAL

Tests need to be fixed as well, are they flaky?

that's because of #783

I'm also fixing #783 in this PR

@timotheecour timotheecour changed the title show cmd used with --verbose (even on success) show cmd used with --verbose (even on success); fix #783 Mar 18, 2020
@timotheecour timotheecour reopened this Mar 18, 2020
Copy link
Collaborator

@dom96 dom96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Thanks!

@dom96 dom96 merged commit a10691b into nim-lang:master Mar 26, 2020
@timotheecour timotheecour deleted the pr_show_cmd branch March 27, 2020 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] travis always fails for nim=#hash after the 1st run
2 participants