-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
show cmd used with --verbose (even on success); fix #783 #781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 15, 2020
dom96
requested changes
Mar 15, 2020
PTAL |
b243d90
to
3da5aeb
Compare
dom96
requested changes
Mar 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests need to be fixed as well, are they flaky?
Closed
ad682fa
to
af0ac00
Compare
…m gist was updated with my patch This reverts commit 8bec860.
dom96
approved these changes
Mar 26, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before PR:
nimble install -y -p:-u:release https://github.com/genotrance/nimgen
doesn't show the actual command used and instead shows the un-informative:
Building nimgen/nimgen.exe using c backend
even with --verbose
after PR:
shows the actual cmd used with --verbose, eg:
which (besides being generally useful) actually shows why -u:release wasn't effective prior to this PR, since
-d:release
was passed after; I'm also fixing that in this PR so that -p:-u:release is honoredfix [CI] travis always fails for nim=#hash after the 1st run #783
example