Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

join room before sending message #12

Merged
merged 2 commits into from
Sep 28, 2021
Merged

Conversation

bboehmke
Copy link
Contributor

With this change it will be checked if the room can be joined before sending the message.

@nim65s
Copy link
Owner

nim65s commented Sep 27, 2021

Nice feature, thanks :)

@codecov-commenter
Copy link

Codecov Report

Merging #12 (d2a3e61) into master (624a1b2) will decrease coverage by 5.05%.
The diff coverage is 79.16%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #12      +/-   ##
==========================================
- Coverage   97.95%   92.89%   -5.06%     
==========================================
  Files           6        6              
  Lines         147      169      +22     
==========================================
+ Hits          144      157      +13     
- Misses          3       12       +9     
Impacted Files Coverage Δ
matrix_webhook/utils.py 75.00% <76.19%> (-14.66%) ⬇️
matrix_webhook/handler.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 624a1b2...d2a3e61. Read the comment docs.

@nim65s
Copy link
Owner

nim65s commented Sep 28, 2021

I took the liberty of updating the unit test. Is this OK for you ?

@bboehmke
Copy link
Contributor Author

sure! I have never done unit test for python so it would be much harder for me to fix this.

@nim65s
Copy link
Owner

nim65s commented Sep 28, 2021

ok !

@nim65s nim65s merged commit 85dd602 into nim65s:master Sep 28, 2021
nim65s added a commit that referenced this pull request Sep 28, 2021
nim65s added a commit that referenced this pull request Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants