[#541] Handle unstable collections detekt warning

nimblehq · Dec 15, 2023 · 391946a · 391946a
1 parent be92fe1
commit 391946a
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/...compose/app/src/main/java/co/nimblehq/template/compose/ui/screens/main/home/HomeScreen.kt b/...compose/app/src/main/java/co/nimblehq/template/compose/ui/screens/main/home/HomeScreen.kt
@@ -22,6 +22,7 @@ import co.nimblehq.template.compose.ui.models.UiModel
 import co.nimblehq.template.compose.ui.showToast
 import co.nimblehq.template.compose.ui.theme.AppTheme.dimensions
 import co.nimblehq.template.compose.ui.theme.ComposeTheme
+import kotlinx.collections.immutable.*
 import timber.log.Timber
 
 @Composable
@@ -33,7 +34,7 @@ fun HomeScreen(
     viewModel.error.collectAsEffect { e -> e.showToast(context) }
     viewModel.navigator.collectAsEffect { destination -> navigator(destination) }
 
-    val uiModels: List<UiModel> by viewModel.uiModels.collectAsStateWithLifecycle()
+    val uiModels: ImmutableList<UiModel> by viewModel.uiModels.collectAsStateWithLifecycle()
 
     HomeScreenContent(
         title = stringResource(id = R.string.app_name),
@@ -44,7 +45,7 @@ fun HomeScreen(
 @Composable
 private fun HomeScreenContent(
     title: String,
-    uiModels: List<UiModel>
+    uiModels: ImmutableList<UiModel>
 ) {
     Column(
         modifier = Modifier.fillMaxSize(),
@@ -67,7 +68,7 @@ private fun HomeScreenPreview() {
     ComposeTheme {
         HomeScreenContent(
             title = stringResource(id = R.string.app_name),
-            uiModels = listOf(UiModel(1), UiModel(2), UiModel(3))
+            uiModels = persistentListOf(UiModel(1), UiModel(2), UiModel(3))
         )
     }
 }
diff --git a/...pose/app/src/main/java/co/nimblehq/template/compose/ui/screens/main/home/HomeViewModel.kt b/...pose/app/src/main/java/co/nimblehq/template/compose/ui/screens/main/home/HomeViewModel.kt
@@ -7,6 +7,7 @@ import co.nimblehq.template.compose.ui.models.UiModel
 import co.nimblehq.template.compose.ui.models.toUiModel
 import co.nimblehq.template.compose.util.DispatchersProvider
 import dagger.hilt.android.lifecycle.HiltViewModel
+import kotlinx.collections.immutable.*
 import kotlinx.coroutines.flow.*
 import javax.inject.Inject
 
@@ -16,15 +17,15 @@ class HomeViewModel @Inject constructor(
     useCase: UseCase,
 ) : BaseViewModel() {
 
-    private val _uiModels = MutableStateFlow<List<UiModel>>(emptyList())
+    private val _uiModels = MutableStateFlow<ImmutableList<UiModel>>(persistentListOf())
     val uiModels = _uiModels.asStateFlow()
 
     init {
         useCase()
             .injectLoading()
             .onEach { result ->
                 val uiModels = result.map { it.toUiModel() }
-                _uiModels.emit(uiModels)
+                _uiModels.emit(uiModels.toImmutableList())
             }
             .flowOn(dispatchersProvider.io)
             .catch { e -> _error.emit(e) }