Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add asStateFlow to the StateFlow variables in ViewModel class #535

Closed
ryan-conway opened this issue Oct 6, 2023 · 1 comment · Fixed by #545
Closed

Add asStateFlow to the StateFlow variables in ViewModel class #535

ryan-conway opened this issue Oct 6, 2023 · 1 comment · Fixed by #545
Assignees
@kaungkhantsoe
Labels
priority : normal type : feature
Milestone
3.25.0

Comments

@ryan-conway
Copy link
Collaborator

ryan-conway commented Oct 6, 2023 •
edited
Loading

Original RFC

Why

Currently we can emit values to our StateFlow variables by casting them to MutableStateFlow. We should update our StateFlow declarations to make them read-only

Solution

  • Update our StateFlow declarations as follows: 
    private val _uiModels = MutableStateFlow<List<UiModel>>(emptyList())
val uiModels = _uiModels.asStateFlow()
  • Apply updates to template-compose and sample-compose ViewModels

Who Benefits?

Developers
@ryan-conway ryan-conway added this to the 3.26.0 milestone Oct 6, 2023
kaungkhantsoe added a commit that referenced this issue Oct 19, 2023
@kaungkhantsoe
[#535] Update state flow to use asStateFlow
f78d181
@kaungkhantsoe kaungkhantsoe mentioned this issue Oct 19, 2023
Merged
@luongvo
Copy link
Member

luongvo commented Oct 20, 2023

@kaungkhantsoe please update your ticket status. Currently, it's in Icebox.

@ryan-conway ryan-conway modified the milestones: 3.26.0, 3.25.0 Oct 20, 2023
kaungkhantsoe added a commit that referenced this issue Oct 20, 2023
@kaungkhantsoe
[#535] Update state flow to use asStateFlow in base viewmodel classes
1d51e5d
ryan-conway added a commit that referenced this issue Oct 23, 2023
@ryan-conway
Merge pull request #545 from nimblehq/feature/535-add-asstateflow-to-…
b90cbe3 
…viewmodel

[#535] Add asStateFlow to the StateFlow variables in ViewModel class
@ryan-conway ryan-conway mentioned this issue Oct 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kaungkhantsoe kaungkhantsoe

Labels
priority : normal type : feature
Projects
None yet
Milestone
3.25.0
Development

Successfully merging a pull request may close this issue.

[#535] Add asStateFlow to the StateFlow variables in ViewModel class nimblehq/android-templates
3 participants
@luongvo @kaungkhantsoe @ryan-conway