Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#165] Fix Github Actions error #166

Merged
merged 1 commit into from
Mar 24, 2022

Conversation

toby-thanathip
Copy link
Contributor

@toby-thanathip toby-thanathip commented Mar 24, 2022

#165

What happened 馃憖

There's a - too many, which is causing the workflows to fail.

Please check the issue for more information

Insight 馃摑

I found the solution from here: einaregilsson/beanstalk-deploy#2 (comment)

Proof Of Work 馃摴

Checks are all succeeded: https://github.com/nimblehq/android-templates/pull/166/checks

@github-actions
Copy link

github-actions bot commented Mar 24, 2022

26 Warnings
鈿狅笍 Uh oh! Your project is under 80% coverage!
鈿狅笍 /home/runner/.gradle/caches/transforms-2/files-2.1/06d4c9e088656fca5c2e85030878bdfb/jetified-timber-4.7.1/jars/lint.jar#L0 - Lint found an issue registry (timber.lint.TimberIssueRegistry) which is older than the current API level; these checks may not work correctly.

Recompile the checks against the latest version. Custom check API version is 1 (3.1), current lint API level is 8 (4.1)

鈿狅笍 /home/runner/.gradle/caches/transforms-2/files-2.1/1df0a6bb6ee6412ef554d91cea854550/jetified-annotation-experimental-1.0.0/jars/lint.jar#L0 - Lint found an issue registry (androidx.annotation.experimental.lint.ExperimentalIssueRegistry) which did not specify the Lint API version it was compiled with.

This means that the lint checks are likely not compatible.

If you are the author of this lint check, make your lint IssueRegistry class contain
聽聽override val api: Int = com.android.tools.lint.detector.api.CURRENT_API
or from Java,
聽聽@OverRide public int getApi() { return com.android.tools.lint.detector.api.ApiKt.CURRENT_API; }

If you are just using lint checks from a third party library you have no control over, you can disable these lint checks (if they misbehave) like this:

聽聽聽聽android {
聽聽聽聽聽聽聽聽lintOptions {
聽聽聽聽聽聽聽聽聽聽聽聽disable "UnsafeExperimentalUsageError",
聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽"UnsafeExperimentalUsageWarning"
聽聽聽聽聽聽聽聽}
聽聽聽聽}

鈿狅笍 /home/runner/.gradle/caches/transforms-2/files-2.1/39cac858e7d5ba86b51192988ab1fc50/jetified-annotation-experimental-1.0.0/jars/lint.jar#L0 - Lint found an issue registry (androidx.annotation.experimental.lint.ExperimentalIssueRegistry) which did not specify the Lint API version it was compiled with.

This means that the lint checks are likely not compatible.

If you are the author of this lint check, make your lint IssueRegistry class contain
聽聽override val api: Int = com.android.tools.lint.detector.api.CURRENT_API
or from Java,
聽聽@OverRide public int getApi() { return com.android.tools.lint.detector.api.ApiKt.CURRENT_API; }

If you are just using lint checks from a third party library you have no control over, you can disable these lint checks (if they misbehave) like this:

聽聽聽聽android {
聽聽聽聽聽聽聽聽lintOptions {
聽聽聽聽聽聽聽聽聽聽聽聽disable "UnsafeExperimentalUsageError",
聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽聽"UnsafeExperimentalUsageWarning"
聽聽聽聽聽聽聽聽}
聽聽聽聽}

鈿狅笍 /home/runner/.gradle/caches/transforms-2/files-2.1/5aa20373e6f3f89e1e7653f1648c50c0/jetified-timber-4.7.1/jars/lint.jar#L0 - Lint found an issue registry (timber.lint.TimberIssueRegistry) which is older than the current API level; these checks may not work correctly.

Recompile the checks against the latest version. Custom check API version is 1 (3.1), current lint API level is 8 (4.1)

鈿狅笍 CoroutineTemplate/app/src/debug/AndroidManifest.xml#L5 - On SDK version 23 and up, your app data will be automatically backed up and restored on app install. Consider adding the attribute android:fullBackupContent to specify an @xml resource which configures which files to backup. More info: https://developer.android.com/training/backup/autosyncapi.html
鈿狅笍 CoroutineTemplate/app/src/main/AndroidManifest.xml#L7 - On SDK version 23 and up, your app data will be automatically backed up and restored on app install. Consider adding the attribute android:fullBackupContent to specify an @xml resource which configures which files to backup. More info: https://developer.android.com/training/backup/autosyncapi.html
鈿狅笍 CoroutineTemplate/app/src/main/AndroidManifest.xml#L12 - Attribute networkSecurityConfig is only used in API level 24 and higher (current min is 23)
鈿狅笍 CoroutineTemplate/app/src/main/res/layout/fragment_home.xml#L12 - Hardcoded string "Next", should use @string resource
鈿狅笍 CoroutineTemplate/app/src/main/res/layout/fragment_home.xml#L22 - Hardcoded string "Jetpack Compose", should use @string resource
鈿狅笍 RxJavaTemplate/app/src/debug/AndroidManifest.xml#L5 - On SDK version 23 and up, your app data will be automatically backed up and restored on app install. Consider adding the attribute android:fullBackupContent to specify an @xml resource which configures which files to backup. More info: https://developer.android.com/training/backup/autosyncapi.html
鈿狅笍 RxJavaTemplate/app/src/main/AndroidManifest.xml#L9 - On SDK version 23 and up, your app data will be automatically backed up and restored on app install. Consider adding the attribute android:fullBackupContent to specify an @xml resource which configures which files to backup. More info: https://developer.android.com/training/backup/autosyncapi.html
鈿狅笍 RxJavaTemplate/app/src/main/AndroidManifest.xml#L14 - Attribute networkSecurityConfig is only used in API level 24 and higher (current min is 23)
鈿狅笍 RxJavaTemplate/app/src/main/res/font/font_circular_family.xml#L2 - The resource R.font.font_circular_family appears to be unused
鈿狅笍 RxJavaTemplate/app/src/main/res/layout/fragment_home.xml#L23 - Hardcoded string "Refresh", should use @string resource
鈿狅笍 RxJavaTemplate/app/src/main/res/layout/fragment_second.xml#L59 - Hardcoded string "Clickable text", should use @string resource
鈿狅笍 RxJavaTemplate/app/src/main/res/layout/fragment_second.xml#L69 - Hardcoded string "Open Camera", should use @string resource
鈿狅笍 RxJavaTemplate/app/src/main/res/layout/fragment_second.xml#L79 - Hardcoded string "Open Post", should use @string resource
鈿狅笍 RxJavaTemplate/app/src/main/res/layout/item_data.xml#L7 - Possible overdraw: Root element paints background ?attr/selectableItemBackground with a theme that also paints a background (inferred theme is @style/AppTheme)
鈿狅笍 RxJavaTemplate/app/src/main/res/values-v23#L0 - This folder configuration (v23) is unnecessary; minSdkVersion is 23. Merge all the resources in this folder into values.
鈿狅笍 RxJavaTemplate/app/src/main/res/values/colors_pallete.xml#L5 - The resource R.color.blue_free_speech_90a appears to be unused
鈿狅笍 RxJavaTemplate/app/src/main/res/values/colors_pallete.xml#L10 - The resource R.color.red_violet_70a appears to be unused
鈿狅笍 RxJavaTemplate/app/src/main/res/values/colors_pallete.xml#L12 - The resource R.color.white appears to be unused
鈿狅笍 RxJavaTemplate/app/src/main/res/values/colors_pallete.xml#L14 - The resource R.color.black appears to be unused
鈿狅笍 RxJavaTemplate/app/src/main/res/values/widget_styles.xml#L9 - The resource R.style.Widget_Template_TextView_Bold appears to be unused
鈿狅笍 RxJavaTemplate/app/src/staging/res/values/strings_url.xml#L3 - The resource R.string.api_endpoint_example appears to be unused

RxJavaTemplate Jacoco report:

馃 Project Code Coverage: 19.52%

Coverage of Modified Files:

File Coverage

Modified Files Not Found In Coverage Report:

publish_docs_to_wiki.yml
run_detekt_and_unit_tests.yml

Codebase cunningly covered by count Shroud 馃

Generated by 馃毇 Danger

@toby-thanathip toby-thanathip self-assigned this Mar 24, 2022
@toby-thanathip toby-thanathip added this to the 3.6.0 milestone Mar 24, 2022
@toby-thanathip toby-thanathip marked this pull request as ready for review March 24, 2022 10:52
Copy link
Member

@luongvo luongvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃悰

Copy link
Member

@chornerman chornerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃殌

@toby-thanathip toby-thanathip merged commit fc69396 into develop Mar 24, 2022
@toby-thanathip toby-thanathip deleted the bug/165-fix-error-in-github-actions branch March 24, 2022 12:24
@toby-thanathip toby-thanathip linked an issue Mar 24, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix error in Github actions workflow
5 participants