Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#228] Add TokenAuthenticator setup #577

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

kaungkhantsoe
Copy link
Contributor

@kaungkhantsoe kaungkhantsoe commented May 28, 2024

#228

What happened 馃憖

TBD

Insight 馃摑

TBD

Proof Of Work 馃摴

Screen.Recording.2024-05-30.at.1.50.37.PM.mov

with(edit()) {
operation(this)
apply()
if (executeWithCommit) commit() else apply()
Copy link

@github-actions github-actions bot May 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

鈿狅笍 Consider using apply() instead; commit writes its data to persistent storage immediately, whereas apply will handle it in the background

Copy link

github-actions bot commented May 28, 2024

13 Warnings
鈿狅笍 Big PR
鈿狅笍 Uh oh! ApiServiceProvider.kt is under 95% coverage!
鈿狅笍 Uh oh! AuthInterceptor.kt is under 95% coverage!
鈿狅笍 Uh oh! AuthStatus.kt is under 95% coverage!
鈿狅笍 Uh oh! BaseEncryptedSharedPreferences.kt is under 95% coverage!
鈿狅笍 Uh oh! BaseSharedPreferences.kt is under 95% coverage!
鈿狅笍 Uh oh! DispatchersProviderImpl.kt is under 95% coverage!
鈿狅笍 Uh oh! EncryptedSharedPreferences.kt is under 95% coverage!
鈿狅笍 Uh oh! NetworkEncryptedSharedPreferences.kt is under 95% coverage!
鈿狅笍 Uh oh! RefreshTokenRequest.kt is under 95% coverage!
鈿狅笍 Uh oh! RequestAuthenticator.kt is under 95% coverage!
鈿狅笍 Uh oh! SharedPreferencesExt.kt is under 95% coverage!
鈿狅笍 Uh oh! Your project is under 80% coverage!

Kover report for template-compose:

馃 Template - Compose Unit Tests Code Coverage: 61.46%

Coverage of Modified Files:

File Coverage
ApiServiceProvider.kt 0.00%
AuthInterceptor.kt 0.00%
AuthPreferenceRepositoryImpl.kt 100.00%
AuthStatus.kt 91.84%
BaseEncryptedSharedPreferences.kt 0.00%
BaseSharedPreferences.kt 7.03%
DispatchersProviderImpl.kt 0.00%
EncryptedSharedPreferences.kt 0.00%
GetAuthStatusUseCase.kt 100.00%
HomeViewModel.kt 100.00%
NetworkEncryptedSharedPreferences.kt 0.00%
OAuthTokenModel.kt 100.00%
OAuthTokenResponse.kt 100.00%
RefreshTokenRequest.kt 76.47%
RefreshTokenUseCase.kt 100.00%
RequestAuthenticator.kt 87.16%
RequestInterceptingDelegate.kt 100.00%
SharedPreferencesExt.kt 0.00%
TokenRepositoryImpl.kt 100.00%
UpdateLoginTokensUseCase.kt 100.00%

Modified Files Not Found In Coverage Report:

.gitignore
ApiService.kt
AppModule.kt
AuthPreferenceRepository.kt
AuthPreferenceRepositoryTest.kt
AuthQualifiers.kt
AuthorizedApiService.kt
CoroutineTestRule.kt
CoroutineTestRule.kt
DispatchersProvider.kt
GetAuthStatusUseCaseTest.kt
HomeViewModelTest.kt
MockUtil.kt
MockUtil.kt
OkHttpClientModule.kt
PreferencesModule.kt
README.md
RefreshTokenUseCaseTest.kt
RequestAuthenticatorTest.kt
RetrofitModule.kt
TokenRepository.kt
TokenRepositoryTest.kt
UpdateLoginTokensUseCaseTest.kt
Versions.kt
api-config.properties.sample
build.gradle.kts

Codebase cunningly covered by count Shroud 馃

Generated by 馃毇 Danger

@kaungkhantsoe kaungkhantsoe force-pushed the feature/228-add-token-authenticator-setup-new branch from fa8f851 to fe479f7 Compare May 30, 2024 04:23
@kaungkhantsoe kaungkhantsoe force-pushed the feature/228-add-token-authenticator-setup-new branch from fe479f7 to 701c368 Compare May 30, 2024 09:41
@kaungkhantsoe kaungkhantsoe marked this pull request as ready for review May 31, 2024 03:19
@kaungkhantsoe kaungkhantsoe marked this pull request as draft May 31, 2024 03:19
@kaungkhantsoe kaungkhantsoe marked this pull request as ready for review June 4, 2024 05:28
@kaungkhantsoe kaungkhantsoe linked an issue Jun 6, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add TokenAuthenticator setup
1 participant