Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#56 Add Bootstrap addons #65

Merged
merged 2 commits into from
Jul 30, 2021
Merged

#56 Add Bootstrap addons #65

merged 2 commits into from
Jul 30, 2021

Conversation

malparty
Copy link
Member

@malparty malparty commented Jul 20, 2021 •
edited
Loading

What happened 👀

  • Add bootstrap add-on
  • Add tests
  • Review code
  • Fill in Proof Of Work

Insight 📝

  • Bootstrap version 5.0.2
  • Using scss, most of the components are commented to enforce an opt-in approach

Proof Of Work 📹

Bootstrap Project from template:

Configured following readme 3x steps (.env file, make install-dependencies & make dev).

  • No error/warning
    image

  • Contains bootstrap css in bundle
    image

  • Ready to use bootstrap classes:
    image

Tests are passing & covering added file & content

3x tests when bootstrap add-on is selected, 3 opposite tests when not selected

image

@malparty malparty linked an issue Jul 20, 2021 that may be closed by this pull request
Add Bootstrap addons #56
Closed
@malparty malparty self-assigned this Jul 20, 2021
@malparty malparty added this to the 2.0.0 milestone Jul 20, 2021
@malparty malparty added this to In progress in 2.0.0 via automation Jul 20, 2021
@malparty malparty force-pushed the feature/50-add-web-variant-menu branch from 4962540 to 9d8f123 Compare July 21, 2021 12:54
@malparty malparty force-pushed the feature/56-add-bootstrap-addon branch from a2684ad to 01e8b87 Compare July 21, 2021 13:11
@malparty malparty force-pushed the feature/50-add-web-variant-menu branch from 9d8f123 to 8e35283 Compare July 23, 2021 06:59
Base automatically changed from feature/50-add-web-variant-menu to feature/50-add-web-variant July 23, 2021 07:29
@malparty malparty force-pushed the feature/56-add-bootstrap-addon branch from 01e8b87 to 04b833b Compare July 23, 2021 08:23
@malparty malparty force-pushed the feature/50-add-web-variant branch 3 times, most recently from 7c02fa2 to 1a7594e Compare July 26, 2021 02:26
@malparty malparty force-pushed the feature/56-add-bootstrap-addon branch 4 times, most recently from d7e60be to 676e265 Compare July 26, 2021 03:54
@malparty malparty marked this pull request as ready for review July 26, 2021 04:20
@malparty malparty moved this from In progress to Review in progress in 2.0.0 Jul 26, 2021
@malparty malparty force-pushed the feature/56-add-bootstrap-addon branch from 676e265 to 5152fa4 Compare July 26, 2021 07:52
gutakk
gutakk reviewed Jul 28, 2021
View reviewed changes
cookiecutter.json Outdated Show resolved Hide resolved
@hoangmirs hoangmirs mentioned this pull request Jul 28, 2021
Merged
2 tasks
@malparty malparty force-pushed the feature/56-add-bootstrap-addon branch from 5152fa4 to 49e1065 Compare July 29, 2021 03:57
2.0.0 automation moved this from Review in progress to Reviewer approved Jul 29, 2021
Base automatically changed from feature/50-add-web-variant to develop July 30, 2021 05:32
@gutakk gutakk merged commit 79a53b8 into develop Jul 30, 2021
2.0.0 automation moved this from Reviewer approved to Done Jul 30, 2021
@gutakk gutakk deleted the feature/56-add-bootstrap-addon branch July 30, 2021 05:33
@gutakk gutakk mentioned this pull request Sep 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoangmirs hoangmirs hoangmirs approved these changes

@gutakk gutakk gutakk approved these changes

Assignees

@malparty malparty

Labels
priority: normal type : feature @2.0.0
Projects
No open projects
2.0.0
Done
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

Add Bootstrap addons
3 participants
@malparty @hoangmirs @gutakk