Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#5] [iOS] Setup CI: Github Actions #23

Merged
merged 8 commits into from
Aug 25, 2023
Merged

[#5] [iOS] Setup CI: Github Actions #23

merged 8 commits into from
Aug 25, 2023

Conversation

markgravity
Copy link
Contributor

@markgravity markgravity commented Aug 8, 2023 •
edited
Loading

What happened 👀

  • Setup CI pipeline for iOS
  • On make.sh:
  • Correct the --exclude './sample' \ so that it won't ignore sample/ios/sample folder
  • Correct the path in ./sample/ios/dangerfile
  • On make_ios.sh:
  • Remove test files as they make a build error (it will be fixed on the ios-template)
  • On android/build.gradle.kts:
  • Change to use rootDir.loadGradleProperties("signing.properties") as the previous one doesn't work on iOS

Insight 📝

n/a

Proof Of Work 📹

CleanShot 2023-08-24 at 15 52 32

@markgravity markgravity force-pushed the feature/5-ios-setup-ci-github-actions branch 3 times, most recently from 4c18b5d to fb52223 Compare August 8, 2023 07:34
@markgravity markgravity force-pushed the feature/5-ios-setup-ci-github-actions branch 9 times, most recently from 47ea12c to 93fd81b Compare August 10, 2023 07:51
@markgravity markgravity self-assigned this Aug 10, 2023
@markgravity markgravity marked this pull request as ready for review August 10, 2023 07:54
@luongvo luongvo mentioned this pull request Aug 11, 2023
Merged
phongvhd93
phongvhd93 reviewed Aug 14, 2023
View reviewed changes
make.sh Outdated Show resolved Hide resolved
shared/build.gradle.kts Outdated Show resolved Hide resolved
phongvhd93
phongvhd93 reviewed Aug 14, 2023
View reviewed changes
.github/workflows/ios_test.yml Outdated Show resolved Hide resolved
.github/workflows/ios_test.yml Outdated Show resolved Hide resolved
.github/workflows/ios_test.yml Outdated Show resolved Hide resolved
@phongvhd93
Copy link
Collaborator

@markgravity; the CI failed, please check the issue.

@markgravity
Copy link
Contributor Author

markgravity commented Aug 14, 2023 •
edited
Loading

@phongvhd93
It gotta fix on your PR first, it's because the Podfile target is 14.0, but our Podspec is 14.1 🙏
https://github.com/nimblehq/kmm-templates/pull/19/files/dc770193cd02994b186874d800b7664e45417d2a#diff-cf9ae3b1eb7273a914f22b1e6d22d8447f88df0e7245a5b856fb751e507b979b

@phongvhd93 phongvhd93 added this to the 0.1.0 milestone Aug 14, 2023
@phongvhd93
Copy link
Collaborator

@phongvhd93 It gotta fix on your PR first, it's because the Podfile target is 14.0, but our Podspec is 14.1 🙏 https://github.com/nimblehq/kmm-templates/pull/19/files/dc770193cd02994b186874d800b7664e45417d2a#diff-cf9ae3b1eb7273a914f22b1e6d22d8447f88df0e7245a5b856fb751e507b979b

I solved the issue and set the ios version based on the user's input.

@phongvhd93 phongvhd93 linked an issue Aug 14, 2023 that may be closed by this pull request
[iOS] Setup CI: Github Actions #5
Closed
Base automatically changed from feature/3-set-up-project-structure-for-ios-app to develop August 15, 2023 07:00
suho
suho reviewed Aug 16, 2023
View reviewed changes
.github/workflows/ios_test.yml Outdated Show resolved Hide resolved
.github/workflows/ios_test.yml Outdated Show resolved Hide resolved
@markgravity markgravity force-pushed the feature/5-ios-setup-ci-github-actions branch 2 times, most recently from d60ee6e to ba6db55 Compare August 25, 2023 03:45
@luongvo
Copy link
Member

luongvo commented Aug 25, 2023

@markgravity is this the latest report from danger? Should we have coverage data there? Should we delete that report message and re-run it to verify again, please?

image

@nimblehq nimblehq deleted a comment from github-actions bot Aug 25, 2023
luongvo
luongvo reviewed Aug 25, 2023
View reviewed changes
Copy link
Member

@luongvo luongvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest lgtm @markgravity

make.sh Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
@nimblehq nimblehq deleted a comment from bot-nimble Aug 25, 2023
@github-actions
Copy link

github-actions bot commented Aug 25, 2023 •
edited
Loading

Current coverage for sample is 18.25%

✅ No files affecting coverage found

Powered by xcov

Generated by 🚫 Danger

@markgravity markgravity force-pushed the feature/5-ios-setup-ci-github-actions branch from 54e9630 to 1157dcc Compare August 25, 2023 06:12
@markgravity markgravity force-pushed the feature/5-ios-setup-ci-github-actions branch from 1157dcc to ebb5630 Compare August 25, 2023 06:12
@markgravity
Copy link
Contributor Author

@luongvo solved at ebb5630

luongvo
luongvo requested changes Aug 25, 2023
View reviewed changes
.github/workflows/test.yml Show resolved Hide resolved
@markgravity markgravity force-pushed the feature/5-ios-setup-ci-github-actions branch from 2efac60 to c57b737 Compare August 25, 2023 08:24
@phongvhd93 phongvhd93 merged commit 4e439d1 into develop Aug 25, 2023
@phongvhd93 phongvhd93 deleted the feature/5-ios-setup-ci-github-actions branch August 25, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luongvo luongvo luongvo approved these changes

@phongvhd93 phongvhd93 phongvhd93 approved these changes

@lydiasama lydiasama Awaiting requested review from lydiasama

@AVI5HEK AVI5HEK Awaiting requested review from AVI5HEK AVI5HEK is a code owner

@kaungkhantsoe kaungkhantsoe Awaiting requested review from kaungkhantsoe kaungkhantsoe is a code owner

@suho suho Awaiting requested review from suho suho is a code owner

Assignees

@markgravity markgravity

Labels
Need Review 👋 type : feature
Projects
None yet
Milestone
0.1.0
Development

Successfully merging this pull request may close these issues.

[iOS] Setup CI: Github Actions
6 participants
@markgravity @phongvhd93 @luongvo @lydiasama @suho @bot-nimble